product-attribute icon indicating copy to clipboard operation
product-attribute copied to clipboard

[18.0][MIG] product_pricelist_direct_print: Migration to 18.0

Open CarlosRoca13 opened this issue 9 months ago • 4 comments

cc @Tecnativa TT54229

ping @sergio-teruel @carlosdauden

CarlosRoca13 avatar Apr 01 '25 07:04 CarlosRoca13

/ocabot migration product_pricelist_direct_print

pedrobaeza avatar Apr 01 '25 11:04 pedrobaeza

@CarlosRoca13 Can you please review https://github.com/OCA/product-attribute/pull/1860 It contains some small improvements.

bosd avatar Apr 02 '25 20:04 bosd

@CarlosRoca13 Can you please review #1860 It contains some small improvements.

Sorry @bosd I did not see your PR. Can you add the recent changes of the module introduced on v16.0?

Another option is for me to cherry-pick your improvements so that authorship is preserved and we also get the changes from v16.0.

What do you prefer?

CarlosRoca13 avatar Apr 03 '25 06:04 CarlosRoca13

@CarlosRoca13 No problem. Some of the commtis might be from after I had made the Pr. Looks like we had different strategys to get to the end goal. (My attempt first merge, then do FW ports)

Judging, by number of commits #1860 was more. But needed some squasing of translation commits.

I have updated the PR now to include the misisng commits. Squashed the transalation commits as well.

This commit is now included: #1499 I was keen on getting it quickly merged, so I could upload a translation file trough weblate.

bosd avatar Apr 03 '25 08:04 bosd

Let's go with the other one that was done before and has been worked to contain all the commits.

pedrobaeza avatar Aug 28 '25 09:08 pedrobaeza