[ADD][16.0] product_english_name module

[bealdav]

cc @legalsylvain @HaraldPanten @rousseldenis @Kev-Roche

[bealdav]

Thanks a lot, @bosd for your review

[bealdav]

Finally works

[bealdav]

Hi @bosd could you check again ?

[HaraldPanten]

@bealdav You should squash your commits.

[bealdav]

@HaraldPanten thanks to notified me. Fixed

[HaraldPanten]

Hi, the commit name should appear without the version number, something like:

[ADD] product_english_name module: description in few words

[bealdav]

@HaraldPanten where this rule is described ?

[pedrobaeza]

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

[bealdav]

I don't see in the doc, that it's required to not add version for a new module.

But I'm ok to change my commit.

[HaraldPanten]

I don't see in the doc, that it's required to not add version for a new module.

But I'm ok to change my commit.

Hi @bealdav We have to follow Odoo's tags, and then apply OCA rules in case there are no examples ([MIG] is one of these use cases).

You can see that Odoo never uses the version number in the commit messages, as well --> https://github.com/odoo/odoo/pulls and here you can see Odoo's guidelines (for tagging) --> https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html#tag-and-module-name

[bealdav]

That's what I have applied, we're OK then [ADD] for adding new modules

[bealdav]

That seems to be nitpicking, but I'm OK to change my commit as said previously.

You can see that Odoo never uses the version number in the commit messages

[bealdav]

Done, thanks for reviews

[HaraldPanten]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1732-by-HaraldPanten-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 22876c2cb36e70579ed15186bca8d3da6aaecaf9. Thanks a lot for contributing to OCA. ❤️