17.0 mig product lot sequence
Thanks, can you please squash that Into the migration commit
@bosd squash is done
Thanks, but pre-commit is no longer happy
@bosd, sorry for the late reply, the pre-commit is good now
Hi @fredericgrall
Thanks for the work done
You are able and willing to continue the PR?.
Could you rebase?
If not i will do a supersede
Hi @Tisho99, Thanks for your comments, I've rebased
/ocabot migration product_lot_sequence
Hi @fredericgrall
Could you please make the last 2 small requested changes?
The migration is almost complete and it would be a shame if the PR is forgotten again
Thank you!
Hi @Tisho99 I think I've made the two changes requested
Hi @fredericgrall I'm not sure if you attended Denis's comments: https://github.com/OCA/product-attribute/pull/1708#discussion_r1940767684
You can improve the title of the PR, as @Tisho99 commented here: https://github.com/OCA/product-attribute/pull/1708#pullrequestreview-2592114138
THX!
@Tisho99 @HaraldPanten , sorry, I've rename PR
@Tisho99, thank you for your help, I've made the correction
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1708-by-HaraldPanten-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 28bc2455eb3f9e25c53bf800a98ceaa9e84cf7a8. Thanks a lot for contributing to OCA. ❤️