product-attribute icon indicating copy to clipboard operation
product-attribute copied to clipboard

17.0 mig product lot sequence

Open fredericgrall opened this issue 1 year ago • 3 comments

fredericgrall avatar Aug 12 '24 10:08 fredericgrall

Thanks, can you please squash that Into the migration commit

bosd avatar Sep 30 '24 14:09 bosd

@bosd squash is done

fredericgrall avatar Sep 30 '24 15:09 fredericgrall

Thanks, but pre-commit is no longer happy

bosd avatar Sep 30 '24 15:09 bosd

@bosd, sorry for the late reply, the pre-commit is good now

fredericgrall avatar Oct 08 '24 09:10 fredericgrall

Hi @fredericgrall

Thanks for the work done

You are able and willing to continue the PR?.

Could you rebase?

If not i will do a supersede

Tisho99 avatar Feb 03 '25 17:02 Tisho99

Hi @Tisho99, Thanks for your comments, I've rebased

fredericgrall avatar Feb 04 '25 04:02 fredericgrall

/ocabot migration product_lot_sequence

rousseldenis avatar Feb 04 '25 09:02 rousseldenis

Hi @fredericgrall

Could you please make the last 2 small requested changes?

The migration is almost complete and it would be a shame if the PR is forgotten again

Thank you!

Tisho99 avatar Feb 07 '25 11:02 Tisho99

Hi @Tisho99 I think I've made the two changes requested

fredericgrall avatar Feb 07 '25 13:02 fredericgrall

Hi @fredericgrall I'm not sure if you attended Denis's comments: https://github.com/OCA/product-attribute/pull/1708#discussion_r1940767684

You can improve the title of the PR, as @Tisho99 commented here: https://github.com/OCA/product-attribute/pull/1708#pullrequestreview-2592114138

THX!

HaraldPanten avatar Feb 07 '25 16:02 HaraldPanten

@Tisho99 @HaraldPanten , sorry, I've rename PR

fredericgrall avatar Feb 07 '25 18:02 fredericgrall

@Tisho99, thank you for your help, I've made the correction

fredericgrall avatar Feb 11 '25 05:02 fredericgrall

/ocabot merge nobump

HaraldPanten avatar Feb 11 '25 08:02 HaraldPanten

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1708-by-HaraldPanten-bump-nobump, awaiting test results.

OCA-git-bot avatar Feb 11 '25 08:02 OCA-git-bot

Congratulations, your PR was merged at 28bc2455eb3f9e25c53bf800a98ceaa9e84cf7a8. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Feb 11 '25 08:02 OCA-git-bot