product-attribute icon indicating copy to clipboard operation
product-attribute copied to clipboard

[17.0][MIG] product_product_template_link

Open astirpe opened this issue 1 year ago • 2 comments

astirpe avatar Jul 01 '24 07:07 astirpe

Other than what @sanderlienaerts mentioned in his review LGTM :+1:

PCatinean avatar Aug 13 '24 08:08 PCatinean

Thanks @astirpe! LGTM

sanderlienaerts avatar Aug 16 '24 12:08 sanderlienaerts

@pedrobaeza do you think you could help out with a review/merge on this PR as well please?

PCatinean avatar Oct 31 '24 10:10 PCatinean

Yes, the current reviewers seem enough for triggering the merge.

/ocabot migration product_product_template_link /ocabot merge nobump

pedrobaeza avatar Oct 31 '24 10:10 pedrobaeza

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1674-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 31 '24 10:10 OCA-git-bot

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1674-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Oct 31 '24 10:10 OCA-git-bot

Uhm, can you please rebase to check the CI?

pedrobaeza avatar Oct 31 '24 10:10 pedrobaeza

@astirpe can you do a rebase when you have some time?

PCatinean avatar Oct 31 '24 11:10 PCatinean

Rebased

astirpe avatar Jan 12 '25 20:01 astirpe

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jan 12 '25 21:01 OCA-git-bot

@pedrobaeza could you please trigger the merge once more?

PCatinean avatar Jan 13 '25 12:01 PCatinean

/ocabot merge nobump

pedrobaeza avatar Jan 13 '25 12:01 pedrobaeza

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1674-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Jan 13 '25 12:01 OCA-git-bot

Congratulations, your PR was merged at 448b4ee0294199db1de868dff1fc9d823836a4d9. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jan 13 '25 12:01 OCA-git-bot