product-attribute icon indicating copy to clipboard operation
product-attribute copied to clipboard

[14.0][IMP] p_sale_manufactured_for: imp when customer is archived

Open TDu opened this issue 2 years ago • 4 comments

When a partner being archived is used on the Manufactured For field That information is not visible anymore on the product form, although it is set. And that product can still not be ordered by any other customers.

Removing the assignation when a customer is archived, fixes both problems.

TDu avatar Oct 12 '23 12:10 TDu

I have added the logging in the chatter, as mentioned above. There was also a bug in the sql execute with multiple records. I did not change the implementation to use an inverse method. I understand the function would be called only when necessary, but is there any performance gain or other reason to do so. Is it related to the

Add the inverse method pattern

in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#id59 ?

TDu avatar Oct 18 '23 08:10 TDu

I have added the logging in the chatter, as mentioned above. There was also a bug in the sql execute with multiple records. I did not change the implementation to use an inverse method. I understand the function would be called only when necessary, but is there any performance gain or other reason to do so. Is it related to the

Add the inverse method pattern

in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#id59 ?

IMO your gain is that is more clear and you don't add yet another override of the write on the partner. Anyway, fine.... :)

simahawk avatar Oct 18 '23 09:10 simahawk

@TDu ping

simahawk avatar Mar 06 '24 11:03 simahawk

@simahawk Updated, will squash if good for you

TDu avatar Apr 19 '24 13:04 TDu

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 18 '24 12:08 github-actions[bot]