pos icon indicating copy to clipboard operation
pos copied to clipboard

[FIX] Allow to inherit CreateOrderButton component

Open flachica opened this issue 1 year ago • 14 comments

Allow inheritance of this component. Without the return you cannot apply the extension

flachica avatar Apr 14 '23 12:04 flachica

Hi @legalsylvain, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Apr 14 '23 12:04 OCA-git-bot

I see the same issue in the other js file (or you can turn them both into esm modules)

Moved to esm modules. Thanks for your review

flachica avatar Apr 17 '23 11:04 flachica

@chienandalu : naive question : what is the interest to use a suffix esm.js ?

legalsylvain avatar Apr 17 '23 11:04 legalsylvain

@chienandalu : naive question : what is the interest to use a suffix esm.js ?

Make pre-commit understand that it is about typescript

flachica avatar Apr 17 '23 12:04 flachica

Hi. Could you rebase ? (there are conflict)

  • could you use git mv to preserve history in the file ?

thanks !

legalsylvain avatar Sep 26 '23 19:09 legalsylvain

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 28 '24 12:01 github-actions[bot]

Hi @flachica. Could you rebase ? so we can merge it.

thanks !

legalsylvain avatar Jan 28 '24 12:01 legalsylvain

Rebased @legalsylvain

flachica avatar Jan 29 '24 08:01 flachica

Hi. I just saw that you didn't used giv mv. So, old files remains in the static/src/js. could you fix it ?

Sorry, I tried to do it correctly just now.

flachica avatar Jan 29 '24 10:01 flachica

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-973-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot avatar Jan 29 '24 11:01 OCA-git-bot

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-973-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Jan 29 '24 12:01 OCA-git-bot

hi @flachica. the test on pos_order_to_sale_order_sale_financial_risk is failing on CI. Did you reproduced the bug locally ?

legalsylvain avatar Jan 29 '24 14:01 legalsylvain

hi @flachica. the test on pos_order_to_sale_order_sale_financial_risk is failing on CI. Did you reproduced the bug locally ?

Ups, I don't use this addon

flachica avatar Jan 29 '24 17:01 flachica

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 09 '24 12:06 github-actions[bot]