pos
pos copied to clipboard
[FIX] Allow to inherit CreateOrderButton component
Allow inheritance of this component. Without the return you cannot apply the extension
Hi @legalsylvain, some modules you are maintaining are being modified, check this out!
I see the same issue in the other js file (or you can turn them both into esm modules)
Moved to esm modules. Thanks for your review
@chienandalu : naive question : what is the interest to use a suffix esm.js ?
@chienandalu : naive question : what is the interest to use a suffix esm.js ?
Make pre-commit understand that it is about typescript
Hi. Could you rebase ? (there are conflict)
- could you use git mv to preserve history in the file ?
thanks !
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
Hi @flachica. Could you rebase ? so we can merge it.
thanks !
Rebased @legalsylvain
Hi. I just saw that you didn't used giv mv. So, old files remains in the static/src/js. could you fix it ?
Sorry, I tried to do it correctly just now.
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-973-by-legalsylvain-bump-patch, awaiting test results.
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-973-by-legalsylvain-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
hi @flachica. the test on pos_order_to_sale_order_sale_financial_risk is failing on CI. Did you reproduced the bug locally ?
hi @flachica. the test on pos_order_to_sale_order_sale_financial_risk is failing on CI. Did you reproduced the bug locally ?
Ups, I don't use this addon
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.