pos
pos copied to clipboard
OCA
[14.0][ADD] pos_product_template_configurator: Add new module
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@legalsylvain the main reason this module was developed was not to change specific features of pos_product_template (the flow was ok overall), but to make it work in a db with ~ 30k variants, as pos_product_template could not handle them correctly
First approach was to try to fix the original module, then we moved to an implmentation of the standard odoo pos configurator with storable/consumable products
The dependency from pos_product_template was added to avoid having conflicting modules in pos runboat
Please instruct us on how we should change readme in order to get merged. Thanks!
Please instruct us on how we should change readme in order to get merged. Thanks!
adding explicit text in readme.rst file, with what you explain here, and add images and reference in the description.rst is enough for me.
Hey @GabbasovDinar, thank you for your Pull Request.
It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:
- diga [email protected] (no github login found)
Appreciation of efforts, OCA CLAbot
Please instruct us on how we should change readme in order to get merged. Thanks!
adding explicit text in readme.rst file, with what you explain here, and add images and reference in the description.rst is enough for me.
Hi @legalsylvain , this was done, think it's good?
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
we noticed issues on dbs with large numbers of products, so decided to develop another variant selection module beginning from odoo standard pos configurator.
Not normal, it has been tested with a db with lots of variants an sometime lot of of axes of variations. I'm bit far now from the project which required this module so I do not know.
@hparfr have all your remarks been addressed correctly?
Yes, thanks. I don't have merging rights on pos.
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-828-by-ivantodorovich-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 9933d12b83b9dc1e6f8d9727514a72b8c1f09368. Thanks a lot for contributing to OCA. ❤️