[BACKPORT][13.0] pos_coupon from odoo 15.0

[ivantodorovich]

This is a backport of pos_coupon module found in odoo/odoo:15.0

It's been adapted to work with sale_coupon module instead of the newly generic coupon module found in the latest version.

[ivantodorovich]

It seems tests are failing in travis, possibly because an incompatibility with another module in this repo. I'm looking into it

[legalsylvain]

Are there licencing issues backporting from odoo:master and not from a released version?

No. I don't see why. we can backport what we want ! The only things is to keep the same licence. (here, @ivantodorovich set LGPL, as the current master version, so it's OK for me).

[pedrobaeza]

Yes, 3 main things:

• Respect same license.
• Make an initial commit with the raw module attributing to Odoo (for example, commit author email [email protected]).
• Put a clause in the README about the lack of CLA

See https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#10backporting-odoo-modules for more details.

[chienandalu]

Thanks everyone. I was wondering what happens if Odoo decided to pull back this code to enterprise in the last minute

[pedrobaeza]

If it has been published once openly, then you can continue using that code forever. You can't backport improvements done in enterprise branch since the closure though, but you can improve it on your own.

[ivantodorovich]

Thanks everyone!

I've amended the first commit, to set Odoo SA <[email protected]> as author. The other two items in @pedrobaeza 's list are already done :)

[ivantodorovich]

Travis error is because of https://github.com/OCA/pos/pull/640 Will rebase this after the other one is merged

[ivantodorovich]

So travis failed again, here's another PR to fix the issue: https://github.com/OCA/pos/pull/641, this time related to pos_fix_search_limit Again I'll rebase this one after the fix is merged and hopefully it would be green :crossed_fingers:

[ivantodorovich]

Still red.. :sweat:

This time pos_empty_home is affecting tours.. of course, as it completely removes the product list if no category is selected. I've made a new PR here: https://github.com/OCA/pos/pull/642 to make it configurable and disabled by default on the demo pos.config: point_of_sale.pos_config_main.

Again, I'll rebase this one after the other one is merged and hopefully it'll be green afterwords :roll_eyes:

[ivantodorovich]

Travis is green :)

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[ivantodorovich]

/ocabot rebase

[OCA-git-bot]

@ivantodorovich The rebase process failed, because command git push --force camptocamp tmp-pr-639:13.0-backport-pos-coupon failed with output:

remote: Permission to camptocamp/pos.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/camptocamp/pos/': The requested URL returned error: 403

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.