pos icon indicating copy to clipboard operation
pos copied to clipboard

[14.0][ADD] pos_require_customer

Open hparfr opened this issue 4 years ago • 8 comments

Block orders with no customer set

hparfr avatar Dec 27 '20 22:12 hparfr

Indeed both modules are doing pretty much the same thing. I agree with @legalsylvain , it's better to migrate the existing module and improve it instead

ivantodorovich avatar Dec 28 '20 14:12 ivantodorovich

Thanks for pointing me out this module. I completely forget this module exists before proposing this pr.

I did a quick look at it, the goal is identical but the behavior is quite different. I will take some time to think about it, but I'm not sure it's worth it to merge these modules.

hparfr avatar Dec 28 '20 23:12 hparfr

Hi @hparfr ,

Indeed it's slightly different..

Coincidently enough I've just got a request for a similar feature, only we need to configure the customer_required per product (not per pricelist, neither per pos config).

I can't imagine how yet but I think there's probably a good way to integrate the existing features + all of this into a single module. I just mention this for the sake of discussion, I don't have an idea myself :sweat_smile:

For the time being I'm not sure it's a good idea to have several "customer required" modules in OCA. I think it's better to find a way to integrate all into 1 module or to treat these requests as custom developments

ivantodorovich avatar Jan 06 '21 18:01 ivantodorovich

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 15 '21 12:08 github-actions[bot]

Given that there may be more than 1 approach to require customers in the PoS, and that they're all valid and doesn't make sense to include them in the same module (at least for now), may I suggest renaming this module to pos_pricelist_require_customer ?

ivantodorovich avatar Aug 15 '21 14:08 ivantodorovich

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Feb 06 '22 12:02 github-actions[bot]

hi there,

superseeded by #748 ?

flotho avatar Feb 19 '22 20:02 flotho

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 10 '22 12:07 github-actions[bot]