pos
pos copied to clipboard
[14.0][ADD] pos_require_customer
Block orders with no customer set
Indeed both modules are doing pretty much the same thing. I agree with @legalsylvain , it's better to migrate the existing module and improve it instead
Thanks for pointing me out this module. I completely forget this module exists before proposing this pr.
I did a quick look at it, the goal is identical but the behavior is quite different. I will take some time to think about it, but I'm not sure it's worth it to merge these modules.
Hi @hparfr ,
Indeed it's slightly different..
Coincidently enough I've just got a request for a similar feature, only we need to configure the customer_required per product (not per pricelist, neither per pos config).
I can't imagine how yet but I think there's probably a good way to integrate the existing features + all of this into a single module. I just mention this for the sake of discussion, I don't have an idea myself :sweat_smile:
For the time being I'm not sure it's a good idea to have several "customer required" modules in OCA. I think it's better to find a way to integrate all into 1 module or to treat these requests as custom developments
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
Given that there may be more than 1 approach to require customers in the PoS, and that they're all valid and doesn't make sense to include them in the same module (at least for now), may I suggest renaming this module to pos_pricelist_require_customer ?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
hi there,
superseeded by #748 ?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.