12.0 mig pos loyalty

[wpichler]

#344 is the original PR - was closed because author is not going to work on it anymore. This is the new PR for it - at time no changes from the original PR. Odoo 13 CE does not seem to have pos_loyalty in CE - so no backport is possible

[oca-clabot]

Hey @wpichler, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

• Gelu [email protected] (no github login found)

Appreciation of efforts, OCA CLAbot

[flotho]

Hi @wpichler

Happy to read that you're sharing some customer profile with us ;-) Could you tell me a bot more regarding the maturity of this PR, I would like to test and help for the review

[wpichler]

Hi @flotho Thanks for the help on the preview What do you mean with sharing a customer profile ?

We tested the module in this PR on a current odoo v12 - and it does work. We do not have it in production environment yet.

[flotho]

We worked together on magento connector, we'll also work on PoS maybe my english is not correct but your customers seems to have the same challenges as ours ;-)

[wpichler]

Ah - ok - this is correct - maybe we should exchange some more profile data - maybe we could share some more work...

I thought that i have forgotten some sensitive customer data in the code...

[ivantodorovich]

Tests need fixing. They're failing in travis

[newtratip]

Hello @wpichler

I would like to help review this PR. Could you check ci/runbot and travis-ci ? I will test this module after that.

Thank you for open PR again :)

[legalsylvain]

Hi @wpichler what is the state of this PR ? regarding ci & runbot. Do you need some help ?

thanks !

[wpichler]

Hi,

PR is abondend - you can take over if you want

[hitrosol]

I think, you have to check the "Available in POS" to make the reward item effective to the POS Order.

The features on this module are really useful. It's too bad it's not ready yet. it's work well in my local

[dsolanki-initos]

@wpichler Can you make Travis happy?

[dsolanki-initos]

@wpichler it would be nice if could we complete this module in v12.

[wpichler]

hi @dsolanki-initos - i will look into it today - thanks for your friendly reminder

[dsolanki-initos]

@wpichler it would be nice if could we complete this module in v12.

[wpichler]

found the unit tests problem - the sample products and customers did changed. Updated the unit tests to reflect these changes, now it should not fail any more...

[dsolanki-initos]

Hi @wpichler Travis is failed because of the web_tour.tour could you check this link https://app.travis-ci.com/github/OCA/pos/jobs/550907114#L2110

[dsolanki-initos]

Hi @wpichler It would be nice if you could fix the failed checks

[dsolanki-initos]

@wpichler Can you please fix the failed checks ?

[dsolanki-initos]

Hello @wpichler, Can you please fix the failed checks ?

[wpichler]

Sorry - no time for it - can you take over - or should we close it ?

[flotho]

Hi @dsolanki-initos @wpichler maybe we could try to set it as a beta release it should ease the first integration. @legalsylvain what's the point o view of OCA for integrating such a good work in an alpha state ?

Regards

[legalsylvain]

Hi. CI should be green. It's a must have to merge for all OCA repo. Otherwise no problem to accept alpha / beta module, as far as there is a quick text in a roadmap file to say what are the next steps.

Regards.

[eLBati]

Taking care of this at https://github.com/OCA/pos/pull/762

[dsolanki-initos]

@wpichler can you please check the failed checks?

[dsolanki-initos]

@wpichler can you please check the failed checks?

[wpichler]

I've now disabled IoT Box support by setting proxy_ip to None in pos.config - so it should not wait for IoT Box on startup

[dsolanki-initos]

@wpichler can we see travis green?

[dsolanki-initos]

@wpichler can we see the Travis green?

[dsolanki-initos]

@wpichler Can we make Travis to green?

[dsolanki-initos]

@wpichler can you please failed checks?