[16.0][IMP] pos_membership_extension: consider membership in shopping cart

[flaenen]

Allow the sale of a product requiring membership if the membership product is in the shopping cart, even if the customer is not yet a member

[OCA-git-bot]

Hi @legalsylvain, some modules you are maintaining are being modified, check this out!

[legalsylvain]

I'm not sure to understand. After the order is confirmed, the state of the customer will allways be "Non member". That is not consistent don't you think ?

[flaenen]

Once the order has been confirmed, the customer becomes a member of the same category as the membership product (Paid Member). This makes it possible to sell the membership at the same time as a product requiring membership.

[polchampion]

@flaenen Tested unsuccessfully on https://lespetitescantines.test.coopiteasy.be/ At first it worked, then I changed the config (among other things I installed l10n_fr_pos_cert_update_draft_order_line and now it doesn't work at all :

[flaenen]

@polchampion On this instance, the membership product is Adhésion and not Adhésion en Cantine. I've added it to the POS.

[polchampion]

@legalsylvain did you take another look here?

[polchampion]

@legalsylvain when you have a moment ;-)

[polchampion]

Tested. Looks broken.

step to reproduce :

* on last runboat,

* open a session

* search "product for member"

* select it.

Result : UX Problem. the product is selected. IMO, the product could be selectable, only if a membership product has been put in the shopping cart before.

Then :

* mark the order as paid.

Result: ⛔ Feature problem. It is possible to sale a product reserved to membership, on an order without customer selected.

@flaenen perhaps a conflict with another module?

[flaenen]

Tested. Looks broken. step to reproduce :

* on last runboat,

* open a session

* search "product for member"

* select it.

Result : UX Problem. the product is selected. IMO, the product could be selectable, only if a membership product has been put in the shopping cart before. Then :

* mark the order as paid.

Result: ⛔ Feature problem. It is possible to sale a product reserved to membership, on an order without customer selected.

@flaenen perhaps a conflict with another module?

pos_sale_product_config_no_variant is not compatible with pos_membership_extension (no call to super in _getAddProductOptions method). This is not related to the proposed evolution.

[legalsylvain]

Tested again.

I'm sorry. I dont understand what is working.

• possibility to sale membership without customer defined. (Doesnt make sense and should be forgotten)
• saling membership to customer doesnt make him a member...

[flaenen]

Tested again.

I'm sorry. I dont understand what is working.

• possibility to sale membership without customer defined. (Doesnt make sense and should be forgotten)
• saling membership to customer doesnt make him a member...

This PR mainly concerns the code that determines whether or not a product can be added to the shopping cart. The modification is therefore very localised. It cannot be the cause of these problems.

pos_membership_extension does not require the creation of an invoice and the selection of a customer. To do this, the pos_membership module must be installed. I suggest adding it as a dependency : #1372

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[polchampion]

@legalsylvain problems you mention have a cause elsewhere or should be fixed after #1372 is merged, can you take another look then?