pos icon indicating copy to clipboard operation
pos copied to clipboard

[16.0][IMP] pos_product_label: improve print_product_labels

Open trisdoan opened this issue 1 year ago • 6 comments

This change

  • Decouple print_product_labels for better inheritance. Notably, print label with extra information such as packaging. Hence, _prepare_product_label_layout_data is used to add more data.

Note

  • The failed test is not related to this change

trisdoan avatar Apr 24 '24 08:04 trisdoan

Hi @ivantodorovich, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Apr 24 '24 08:04 OCA-git-bot

/ocabot merge patch

ivantodorovich avatar Apr 25 '24 11:04 ivantodorovich

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-1181-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot avatar Apr 25 '24 11:04 OCA-git-bot

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1181-by-ivantodorovich-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 25 '24 11:04 OCA-git-bot

/ocabot rebase

ivantodorovich avatar Apr 25 '24 11:04 ivantodorovich

Congratulations, PR rebased to 16.0.

OCA-git-bot avatar Apr 25 '24 11:04 OCA-git-bot

/ocabot merge patch

dreispt avatar May 18 '24 16:05 dreispt

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1181-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar May 18 '24 16:05 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1181-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar May 18 '24 16:05 OCA-git-bot

Hello @dreispt, please help to remerge :pray:

trisdoan avatar May 19 '24 02:05 trisdoan

Hi @dreispt could you retry the merge please ?

cyrilmanuel avatar Jun 28 '24 06:06 cyrilmanuel

Hiii @ivantodorovich can you retry the merge ?

cyrilmanuel avatar Jul 01 '24 07:07 cyrilmanuel

let's try that again

/ocabot merge patch

ivantodorovich avatar Jul 01 '24 12:07 ivantodorovich

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1181-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot avatar Jul 01 '24 12:07 OCA-git-bot

Congratulations, your PR was merged at 3e9ce91ff298e924f48d0bf5f65c454383fd13f5. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 01 '24 12:07 OCA-git-bot