pms icon indicating copy to clipboard operation
pms copied to clipboard

[IMP]pms: includes board services in cancelation penalty

Open braisab opened this issue 6 months ago • 1 comments

This pull request introduces enhancements to the penalty calculation logic in the pms_reservation model, specifically targeting board services. The changes ensure penalties account for board services consumed before or after the reservation dates, improving accuracy in penalty computations.

Enhancements to penalty calculation:

  • pms/models/pms_reservation.py: Added a new helper method _get_board_services_penalty_amount to calculate the penalty amount for board services based on their consumption dates relative to the reservation dates. Only services consumed "before" or "after" the reservation dates are considered, excluding those consumed on the first or last day.
  • pms/models/pms_reservation.py: Updated the _check_cancel_penalty method to include the penalty amount from board services by invoking the _get_board_services_penalty_amount method when service_ids are present.

braisab avatar Jun 17 '25 09:06 braisab

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 19 '25 12:10 github-actions[bot]