payroll icon indicating copy to clipboard operation
payroll copied to clipboard
verified publisher icon OCA

[17.0][MIG] hr_payroll_document: Migration to 17.0

Open peluko00 opened this issue 1 year ago • 9 comments

Module migrated to version 17.0

cc https://github.com/APSL 155370 @miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

  • [Issue] https://github.com/OCA/payroll/issues/135

New improvements:

  • New menu item to access to full payrolls of all employees into a new view
  • Button in each employee form to filter the payrolls by the specific employee with counter and the same button for the user

peluko00 avatar May 20 '24 14:05 peluko00

Hi @nimarosa, @appstogrow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar May 20 '24 14:05 OCA-git-bot

Hi @peluko00 ,

I have tried to test the module with the pdf document that comes in the tests but I get this notification "Employees not found".

It would be nice to add a usage section in the Readme.

lbarry-apsl avatar May 27 '24 11:05 lbarry-apsl

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 29 '24 12:09 github-actions[bot]

Hi @nimarosa, can you reopen the pr?

peluko00 avatar Nov 04 '24 07:11 peluko00

Hi @nimarosa, @appstogrow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Nov 04 '24 08:11 OCA-git-bot

Thanks!. Can you review it @nimarosa ?

peluko00 avatar Nov 04 '24 09:11 peluko00

Please remove the changes to the unrelated payroll module. Changes introduced that are not strictly related to the migration are better in a separate commit. That helps understanding the changes and backporting them.

Done, thanks! Can you review it please @dreispt @nimarosa ?

peluko00 avatar Jan 07 '25 07:01 peluko00

@peluko00 I agree with @dreispt , i have not idea why this module will be useful. But since it's not interact with payroll module, if you want it merged if you find it useful. please check runboat errors and we can merge it.

nimarosa avatar May 06 '25 23:05 nimarosa

@peluko00 I agree with @dreispt , i have not idea why this module will be useful. But since it's not interact with payroll module, if you want it merged if you find it useful. please check runboat errors and we can merge it.

This module split payrolls of one document with multiple payrolls and insert this payrolls for each employee by vat. I'll do a new when I can for extend the README

peluko00 avatar May 09 '25 05:05 peluko00

Can you review again please @nimarosa for merge please?

peluko00 avatar Aug 22 '25 05:08 peluko00

Seems it's ready to merge @nimarosa ?

peluko00 avatar Oct 20 '25 06:10 peluko00

/ocabot merge nobump /ocabot migration hr_payroll_document

dreispt avatar Oct 20 '25 07:10 dreispt

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-152-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 20 '25 07:10 OCA-git-bot

Congratulations, your PR was merged at e46a123efcf041e00b2f8fb76eee03ae04193d0d. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 20 '25 07:10 OCA-git-bot