payroll icon indicating copy to clipboard operation
payroll copied to clipboard

[16.0][ADD] payroll_fetch_prev_month

Open norlinhenrik opened this issue 1 year ago • 5 comments

norlinhenrik avatar Feb 15 '24 21:02 norlinhenrik

Hi @nimarosa, @appstogrow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Feb 15 '24 21:02 OCA-git-bot

Hello Henrik, i think this can be on another module. I don't see why someone would need to fetch last month leaves. Maybe in another module will be okay if anyone want to use it. Now the payroll module have all the hooks to do that in external modules so i think we can do it that way.

Also if this conflicts with payroll_period it's another good reason to be another module, since a lot of people use payroll_period. Finally, i think changing the dates "on the fly" can lead to bugs in another modules depending on payroll too.

I see that you are changing the maintainer tag, feel free to do it in another PR and i will merge it.

nimarosa avatar Mar 03 '24 19:03 nimarosa

I put the logic into a new module and added a hook in hr.payslip. @mtelahun @nimarosa What do you think?

norlinhenrik avatar May 28 '24 07:05 norlinhenrik

Looks good to me.

mtelahun avatar May 31 '24 05:05 mtelahun

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 29 '24 12:09 github-actions[bot]