partner-contact icon indicating copy to clipboard operation
partner-contact copied to clipboard

[17.0][MIG] partner_contact_weight: Migration to 17.0

Open vehi-invitu opened this issue 9 months ago • 8 comments

cc @cvinh

vehi-invitu avatar Mar 25 '25 20:03 vehi-invitu

IF it is a migration you are not keeping the history :thinking:

etobella avatar Mar 25 '25 21:03 etobella

Please read the guidelines how to migrate Can you put PR in draft, we'll make it open when it's ready

cvinh avatar Mar 25 '25 22:03 cvinh

@legalsylvain it was already in this repo but in version 10.

vehi-invitu avatar Mar 27 '25 23:03 vehi-invitu

@legalsylvain it was already in this repo but in version 10.

Yes i saw. But what do you think about my proposal ?

legalsylvain avatar Mar 28 '25 06:03 legalsylvain

@legalsylvain vertical-health does not exists in OCA and vertical-medical has been dead for 7 years.

I would recommend to keep it here. But I don't have an strong opinion on this.

etobella avatar Mar 28 '25 06:03 etobella

@legalsylvain partner weight is not so vertical... it can be used in fitness or sport use cases. I don't have strong opinion neither, you decide...

cvinh avatar Mar 28 '25 07:03 cvinh

hi @cvinh and @etobella

I think that such modules (partner_contact_weight, pos_partner_birthdate_weight_mandatory, pos_partner_weight are very specific. (pos or not).

IMO, it will be used only (or mainly) in an medical / hospital / pharmacy context. Indeed it can be used in areas related to health, such as sport, but we're still talking about biological data.

For this reason, I think we should put that modules in a dedicated medical / health repository.

I propose you :

  • to use the existing repo, here : https://github.com/OCA/vertical-medical/ (It is totally empty ...). (only "dev" branches contained modules, but they have been deleted)
  • to propose a PR to add your github login in this list, so you'll have some write access on this repo. https://github.com/OCA/repo-maintainer-conf/blob/master/conf/psc/vertical.yml#L102

(you work daily in medical area, and you regularly contribute to OCA, so it makes sense if you're are responsible of this repo).

What do you think ?

legalsylvain avatar Mar 28 '25 08:03 legalsylvain

Okay

cvinh avatar Mar 28 '25 08:03 cvinh

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 10 '25 12:08 github-actions[bot]