[17.0] [IMP] partner_contact_gender: improve readme and icon

[polchampion]

OCA Days workshop - improving documentation by fucntionals

[polchampion]

@gurneyalex Do you think this can be merged?

[polchampion]

@TumbaoJu My OCA Days PR seems stuck... how should I proceed?

[houssine78]

@polchampion you're missing some approvals to allow the merge. Could squash your commits into one as asked by Rémi? ping me back when it's done I'll approve the PR.

[TumbaoJu]

@remi-filament @houssine78 : As discussed during the OCA Days, the commit squash is not required for Read me PR.

Non-technical persons wrote those PR and have not the knowledge to be able to squash the commits so we agreed that for Read me PR, it would not be mandatory.

Thank you in advance for your help. @polchampion : FYI

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[houssine78]

Hi @TumbaoJu ,

Thanks for the info, I wasn't aware of this.

[houssine78]

Hi @pedrobaeza this PR is ready for merging

[rousseldenis]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1851-by-rousseldenis-bump-patch, awaiting test results.

[pedrobaeza]

Please squash both icon commits into one. About the icon itself, I understand the motivations for changing it, but I think the icon is not self-representative. It can be easily confused with a country flag, and it's also not incorporating a contact representation. It can be at least a merge of the avatar icon (like https://github.com/OCA/partner-contact/blob/16.0/partner_contact_lang/static/description/icon.png) with the flag in one corner.

[OCA-git-bot]

Congratulations, your PR was merged at b6be5b7b49a7be2dd0ab31f7f5a108875d3e759b. Thanks a lot for contributing to OCA. ❤️