[MIG] stock_account_operating_unit: Migration to 17.0

Open BT-dherreros opened this issue 1 year ago • 3 comments

Jan 03 '25 14:01 BT-dherreros

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Jan 28 '25 10:01 OCA-git-bot

Functional review LGTM

I had another functional look at this code and it seems to be creating 2 journal entries, one that seems to be correct and comes form Odoo's core and the other one coming from this migrated module with an incorrect ref field. Could you confirm this? maybe this migration is not needed anymore

Feb 03 '25 09:02 BT-dherreros

@AaronHForgeFlow I have removed the action_done inherited method. I also adapted the unit tests that were failing. Do you think my changes to the tests make sense? To me it does of course, as the balances must change with different amount of moves.

Feb 14 '25 16:02 BT-dherreros

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Jul 13 '25 12:07 github-actions[bot]