odoo-pim icon indicating copy to clipboard operation
odoo-pim copied to clipboard

[FIX] attribute_set: fix wizard validate button

Open kobros-tech opened this issue 11 months ago • 10 comments

A fix for issue: https://github.com/OCA/odoo-pim/issues/198

kobros-tech avatar Feb 13 '25 23:02 kobros-tech

https://github.com/user-attachments/assets/23260801-958c-487c-8cef-0a993ae4ebdd

kobros-tech avatar Feb 14 '25 00:02 kobros-tech

@rvalyi Can we review and get this PR merged, it is a critical issue?

kobros-tech avatar Feb 14 '25 17:02 kobros-tech

Screenshot from 2025-02-16 23-29-23

kobros-tech avatar Feb 16 '25 20:02 kobros-tech

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Mar 12 '25 12:03 OCA-git-bot

@kobros-tech Could you merge duplicate commits ?

rousseldenis avatar Mar 12 '25 12:03 rousseldenis

And fix typo in commit message s/vlidate/validate

rousseldenis avatar Mar 12 '25 12:03 rousseldenis

@kobros-tech Could you merge duplicate commits ?

I am sorry didn't catch up, which commits should I merge?

kobros-tech avatar Mar 12 '25 13:03 kobros-tech

@rousseldenis

How do you think now?

kobros-tech avatar Mar 12 '25 21:03 kobros-tech

I think you got it. Yeah he meant use something like git rebase HEAD~5 and then squash some commits / chatGPT is your friend for more details.

there were 3 commits, 2 of them are related so I squashed them, but the last one is not related and I needed it to post forward to higher branches

kobros-tech avatar Mar 13 '25 20:03 kobros-tech

I think you got it. Yeah he meant use something like git rebase HEAD~5 and then squash some commits / chatGPT is your friend for more details.

there were 3 commits, 2 of them are related so I squashed them, but the last one is not related and I needed it to post forward to higher branches

I got that and I approved, sorry if that wasn't clear. Let's see if it's ok for @rousseldenis as well now...

rvalyi avatar Mar 14 '25 01:03 rvalyi

@rousseldenis

shall I squash these two commits into a single one?

kobros-tech avatar Jun 16 '25 14:06 kobros-tech

/ocabot merge minor

rousseldenis avatar Jul 03 '25 09:07 rousseldenis

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-199-by-rousseldenis-bump-minor, awaiting test results.

OCA-git-bot avatar Jul 03 '25 09:07 OCA-git-bot

Congratulations, your PR was merged at bcfee4c3077b92b49479380dabec2672d95b1150. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 03 '25 09:07 OCA-git-bot