OCA
[17.0][MIG] attribute_set: Migration to 17.0
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@rousseldenis Can we suspend merging for a while please?
@kobros-tech as I see you seem to be a serious contributor, I put the PR as draft to prevent an accidental merge as you requested it. Please explain us why it should not be merged yet.
cc @dnplkndll I let you comment eventually, I didn't analyse the PR, but I'm amongst the persons at the origin of the module and @kobros-tech might have some good reason for not merging it yet, so let's see that...
@rousseldenis Can we suspend merging for a while please?
@kobros-tech as I see you seem to be a serious contributor, I put the PR as draft to prevent an accidental merge as you requested it. Please explain us why it should not be merged yet.
cc @dnplkndll I let you comment eventually, I didn't analyse the PR, but I'm amongst the persons at the origin of the module and @kobros-tech might have some good reason for not merging it yet, so let's see that...
yes, thanks I found some issues in 14.0 #198 #199 and other more in the PR for 16.0
I have just wrote an issue on that and made a fix PR, can you review the PR and merge it in 14.0?
@rousseldenis Can we suspend merging for a while please?
@kobros-tech as I see you seem to be a serious contributor, I put the PR as draft to prevent an accidental merge as you requested it. Please explain us why it should not be merged yet.
cc @dnplkndll I let you comment eventually, I didn't analyse the PR, but I'm amongst the persons at the origin of the module and @kobros-tech might have some good reason for not merging it yet, so let's see that...
We are at the point of cleanup and then review. just curious, was this used on other types of sites and not odoo _website? I had planned to make the module compatible with the e-commerce and merge the attributes with templates and variables while ideating the variant selectors, on product_attribute_set. while we do not currently use odoo from ecom it seems to make sense to keep moving the native functionality closer to usable with the 18 rear only available and owl.
should some review be done on when and why to use pim attribute_set over the properties that are on crm now? not sure if moving forward those serial properties will be on more things. but there seems to still be a need to control product templates level attribute values for the search and compare of products.
Hi @rousseldenis , @rvalyi We have made review and tests on the module for version 17.0, we have introduced a big change due to the change in odoo itself.
I assure that this version is at the same quality as the older version and even move efficient.
Please, review and merge if you are comfortable, and I only requested to delay the merge util I fix the issues that I suspected and you will observe the outcome.
Thanks, and I will remind you of what Mr. Don said about extending this project to show product attributes on website e-commerce.
We need your opinion...
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}