oca-ci icon indicating copy to clipboard operation
oca-ci copied to clipboard

[FIX] Minimum Python version Odoo 12

Open SirTakobi opened this issue 3 years ago • 7 comments

Minimum version should be 3.5:

Odoo requires Python 3.5 or later to run

(ref. https://www.odoo.com/documentation/12.0/administration/install.html#python)

I have tried to remove the setuptools constraint too, it might be no more needed

This will need to be coordinated with other changes in https://github.com/OCA/oca-addons-repo-template/blob/510592efb895bc586a22d1808d72b7125b645d86/src/.github/workflows/%7B%25%20if%20ci%20%3D%3D%20'GitHub'%20%25%7Dtest.yml%7B%25%20endif%20%25%7D.jinja#L19

SirTakobi avatar Dec 16 '22 10:12 SirTakobi

The Chrome installation error might be related to https://support.google.com/chrome/thread/192592808

SirTakobi avatar Dec 16 '22 10:12 SirTakobi

@sbidoul other than the Chrome error (should be temporary), any opinion about the Python version change? I'm afraid it is a pretty big change, but maybe it was already discussed and 3.6 had been chosen for some reason I don't know

SirTakobi avatar Dec 16 '22 10:12 SirTakobi

Ow I had not received notifications of this failing.

This can be fixed by running the job on ubuntu-20.04 instead of ubuntu-latest for python <3.8.

sbidoul avatar Dec 16 '22 10:12 sbidoul

We have an example here: https://github.com/OCA/oca-addons-repo-template/blob/510592efb895bc586a22d1808d72b7125b645d86/.github/workflows/test.yml#L12-L36

sbidoul avatar Dec 16 '22 10:12 sbidoul

Ow I had not received notifications of this failing.

This can be fixed by running the job on ubuntu-20.04 instead of ubuntu-latest for python <3.8.

Thanks, I have pinned the Ubuntu version but that does not appear to be the issue for chrome download

SirTakobi avatar Dec 16 '22 11:12 SirTakobi

any opinion about the Python version change?

Well that risks making some branches red, and I'd say it is late to change that for such an old version.

TBH, python version compatibility with Odoo is a bit of a mess. It's very hard to get a reliable information about which python versions are really supported. So we look at which python version is used on Odoo runbot and odoo.sh and test with that in OCA.

sbidoul avatar Dec 16 '22 11:12 sbidoul

any opinion about the Python version change?

Well that risks making some branches red, and I'd say it is late to change that for such an old version.

TBH, python version compatibility with Odoo is a bit of a mess. It's very hard to get a reliable information about which python versions are really supported. So we look at which python version is used on Odoo runbot and odoo.sh and test with that in OCA.

What do you mean really supported? The documentation might be wrong/not updated, but the truth is in the code too: Odoo 12.0, should be able to run at least in 3.5 because it is in https://github.com/odoo/odoo/blob/271b9468c999454527f106b4db177665afeef8ca/setup.py#L59.

SirTakobi avatar Jan 02 '23 09:01 SirTakobi