multi-company icon indicating copy to clipboard operation
multi-company copied to clipboard

[14.0][IMP] product supplierinfo intercompany[_multi_company]: refactor, archiving

Open aleuffre opened this issue 5 months ago • 3 comments

These commits

  • slightly refactor these two modules so that the method doesn't need to be overwritten
  • implement deletion and recreation of supplierinfo when archiving and unarchiving product templates and product pricelists

More details in each commit

aleuffre avatar Jul 15 '25 13:07 aleuffre

Hi @PierrickBrun, @sebastienbeau, @kevinkhao, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jul 15 '25 13:07 OCA-git-bot

for _condition_supplierinfo_create_or_update

can you also add these fields such that when they are changed the pricelist recomputes?

this is when it is based on cost field and similars

https://github.com/OCA/multi-company/pull/821/files#diff-19f4129027b1cecdf793d8eb674abc4a90b136c629ee2b4cae958ff1a5f8d2f9R75

Thank you for your feedback!

I cherry-picked your commit as well as a previous one about currency. The modules are quite different, and doing more is definitely outside the scope of this PR.

I realized after I had already started that the change you requested wasn't strictly necessary because in v14 pricelists are recomputed ALWAYS, there was no list of fields to check against, and therefore there was no need to add any fields to that list. Still, while I was at it, I added it. Let me know what you think.

aleuffre avatar Aug 20 '25 13:08 aleuffre

for _condition_supplierinfo_create_or_update can you also add these fields such that when they are changed the pricelist recomputes? this is when it is based on cost field and similars https://github.com/OCA/multi-company/pull/821/files#diff-19f4129027b1cecdf793d8eb674abc4a90b136c629ee2b4cae958ff1a5f8d2f9R75

Thank you for your feedback!

I cherry-picked your commit as well as a previous one about currency. The modules are quite different, and doing more is definitely outside the scope of this PR.

I realized after I had already started that the change you requested wasn't strictly necessary because in v14 pricelists are recomputed ALWAYS, there was no list of fields to check against, and therefore there was no need to add any fields to that list. Still, while I was at it, I added it. Let me know what you think.

great. For me it is interesting because this module is having lots of changes in between versions but nobody is set as maintainer so not guiding the boat and it was just to make sure we are following the right approach so when you migrate to v16 for instance you get the same features and non breaking changes

giarve avatar Aug 20 '25 14:08 giarve