OCA
[16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments
Remove lots of code thanks to https://github.com/OCA/multi-company/pull/760.
Also, call the new fill_company_ids hook, to respect company assignments done before the module installation.
Draft until:
- [x] https://github.com/OCA/multi-company/pull/760
Instructions for functional tests: This refactor is internal and should not be noticed functionally. The module product_multi_company should work just as always. If so, then this is good.
@moduon MT-8873
This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-762-by-pedrobaeza-bump-major, awaiting test results.
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-762-by-pedrobaeza-bump-major.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@yajo The tests for this module are broken. Please check https://github.com/OCA/multi-company/actions/runs/13632724910/job/38103974812#step:8:847. Are you available to fix this? Additionally, Pedro asks to forward port these fixes to v17.0 too.
@yajo Just a kind reminder here. Migration to 18.0 is already in progress, and it is probably better if we can include this change.
Please could you merge? This one is approved and tests are already fixed. Thanks!
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-762-by-pedrobaeza-bump-major, awaiting test results.
Congratulations, your PR was merged at 66de6cae0dfbffc30408852f0acc4e56aefbd25f. Thanks a lot for contributing to OCA. ❤️
@yajo I have notified in the v18 migration, I guess it is still needed the fwport to v17, right?
We're skipping v17. I'm sorry about that 😅
But anybody can do the fwport if needed.