mis-builder icon indicating copy to clipboard operation
mis-builder copied to clipboard

[IMP]-mis_builder-enhance-multi-company-support

Open geraldo29 opened this issue 6 months ago • 6 comments

Summary of Changes Made

  1. KPI Matrix Enhancement (kpimatrix.py) Problem Solved: The original code assumed accounts always had a single company_id field Solution: Enhanced _get_account_name() method to handle both: Single company accounts (company_id field) Multi-company accounts (company_ids field) Key Improvements: Safe field checking with hasattr() Smart display limiting to 3 companies max Graceful fallback when company info is missing

  2. Accounting Expression Parser Enhancement (aep.py) Problem Solved: Runtime errors when processing accounting data from companies not pre-loaded in company_rates Solution: Added dynamic company rate calculation Key Improvements: On-demand rate calculation for missing companies Proper currency conversion handling

Description

Did not create issue

Test

added unit tests

geraldo29 avatar Jun 25 '25 08:06 geraldo29

Hi @sbidoul, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jun 25 '25 08:06 OCA-git-bot

LGTM!

BhaveshHeliconia avatar Jul 15 '25 12:07 BhaveshHeliconia

Hello @OCA/mis-builder-maintainers is this possible to merge, already checked and working fine.

BhaveshHeliconia avatar Jul 28 '25 10:07 BhaveshHeliconia

Hello, could you do separate PRs for the two topics, which seem independent? This is will facilitate review.

Also, please don't mix bug fixes and improvements, that will also make things quicker to review.

sbidoul avatar Jul 28 '25 10:07 sbidoul

The KPI Matrix Enhancement (kpimatrix.py) fix works

speltot avatar Aug 05 '25 16:08 speltot

@geraldo29 Thanks for the fixes! Because you seem to be too busy to follow-up, I've split up the account company_id issue to https://github.com/OCA/mis-builder/pull/730 as the reviewer requested.

StefanRijnhart avatar Sep 22 '25 07:09 StefanRijnhart