mis-builder icon indicating copy to clipboard operation
mis-builder copied to clipboard

[14.0][IMP] mis_builder: pivot view

Open Chionne27 opened this issue 9 months ago • 4 comments

Thanks for your pull request. Please take a moment to review if it meets the following guidelines.

Description

Before coding, it is recommended to create an issue to discuss the problem or feature you want to add. If you did not, don't worry, we can discuss on the PR too.

If there is a pre-existing issue that your PR implements or fixes, add a pointer to it in the PR description.

If your PR is simple enough that it does not require a preliminary discussion, then make sure to explain what it does (i.e. why the change is necessary).

Test

Don't forget to add unit tests. If your PR fixes a bug, prefer creating a separate commit for the test so we one see that your test reproduces the bug and is fixed by the PR.

Target branch

MIS Builder is actively maintained for Odoo versions 9, 10, 11 and 12.

If your feature is applicable with the same implementation to all these versions, please target branch 10.0. Maintainers will port it to 9, 11 and 12 soon after merging.

In the rare cases your feature or implementation is specific to an Odoo version, then target the corresponding branch.

CLA

Have you signed the OCA Contributor License Agreement? If not, please visit https://odoo-community.org/page/cla to learn how.

Changelog entry

This projects uses towncrier to generate it's changelog. Make sure your PR includes a changelog entry in <addon>/readme/newsfragments/. It must have the issue or PR number as name, and one of .feature, .bugfix, .doc (for documentation improvements), .misc (if a ticket has been closed, but it is not of interest to users). The changelog entry must be reasonably short and phrased in a way that is understandable by end users.

Documentation

Consider improving the documention in docs/.

Chionne27 avatar Mar 26 '25 11:03 Chionne27

Hi @sbidoul, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Mar 26 '25 11:03 OCA-git-bot

This PR adds a pivot view to the MIS report section

Chionne27 avatar Apr 01 '25 12:04 Chionne27

Thanks! Can you elaborate the use case, as it's not obvious to my why this is useful.

sbidoul avatar Apr 01 '25 12:04 sbidoul

Thanks! Can you elaborate the use case, as it's not obvious to my why this is useful.

Hi @sbidoul. This improvement could be useful better analysis of the Mis reports

Chionne27 avatar Apr 01 '25 13:04 Chionne27

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 17 '25 12:08 github-actions[bot]

@OCA/mis-builder-maintainers can someone re-open and have a look? It's just a one-line change to add the pivot view during the drilldown.

SirPyTech avatar Sep 23 '25 08:09 SirPyTech

Hi @sbidoul, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Sep 23 '25 10:09 OCA-git-bot

/ocabot merge minor

Thanks for your patience.

sbidoul avatar Oct 27 '25 17:10 sbidoul

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-674-by-sbidoul-bump-minor, awaiting test results.

OCA-git-bot avatar Oct 27 '25 17:10 OCA-git-bot

Will you port this to 18?

sbidoul avatar Oct 27 '25 17:10 sbidoul

Congratulations, your PR was merged at 063d2be69049d91e02f4e441c02d71ce0e2591bc. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 27 '25 18:10 OCA-git-bot

This implementation is not necessary in v18 because the pivot view is already set for the drilldown. https://github.com/OCA/mis-builder/blob/052622a28642ee970fd59e21c180245f8d593960/mis_builder/models/mis_report_instance.py#L947

Chionne27 avatar Nov 05 '25 08:11 Chionne27

Nice. Thanks for the feedback.

sbidoul avatar Nov 05 '25 08:11 sbidoul