mis-builder icon indicating copy to clipboard operation
mis-builder copied to clipboard

Migration to version 18.0

Open OCA-git-bot opened this issue 1 year ago • 6 comments

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

  • [ ] mis_builder - By @chaule97 - #652
  • [ ] mis_builder_budget - By @chaule97 - #653
  • [ ] mis_builder_demo

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

OCA-git-bot avatar Oct 06 '24 14:10 OCA-git-bot

For v18, I would like to create new security groups, and use these instead of the accounting groups to control access to MIS reports and templates:

  • MIS Report Viewer: ro access to MIS Reports
  • MIS Report Administrator: rw access to MIS Reports
  • MIS Report Template Administrator: rw access to templates and styles

For budgets:

  • MIS Budget Viewer: ro access to MIS Budgets
  • MIS Budget Administrator: rw access to MIS Budgets

sbidoul avatar Nov 10 '24 11:11 sbidoul

On the budgets part: does it make sense to not access MIS budgets, but see the results in a MIS report? I consider OK to have a rw access group, but ro should be the MIS base one.

pedrobaeza avatar Nov 11 '24 15:11 pedrobaeza

It is actually possible to view MIS Reports without access to account.move.line. So, in the same spirit, since budget information can be sensitive data, I'd say it's worth a separate security group. Viewer of MIS Reports will then not be able to view reports involving budget data, but other reports will work.

sbidoul avatar Nov 11 '24 16:11 sbidoul

I think it will be weird to access the report, but not to be able to preview it/export it. Let's block it by access rules (or inheriting the _check_access method) for not viewing them in the list.

pedrobaeza avatar Nov 11 '24 16:11 pedrobaeza

working on mis_builder

chaule97 avatar Nov 19 '24 04:11 chaule97

We've modified some code in the mis_builder to make it compatible with Odoo 18. However, certain features, such as the ability to jump to details from the generated reports, are not working. Could we proceed with the merge?

z69426 avatar May 09 '25 03:05 z69426

duplicate error

RPC_ERROR

Odoo Server Error

Occured on 127.0.0.1:8069 on model mis.report.instance and id 18 on 2025-06-03 04:00:57 GMT

Traceback (most recent call last): File "/opt/odoo18/odoo/models.py", line 6252, in ensure_one _id, = self._ids ^^^^ ValueError: too many values to unpack (expected 1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last): File "/opt/odoo18/odoo/http.py", line 1976, in _transactioning return service_model.retrying(func, env=self.env) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/service/model.py", line 156, in retrying result = func() ^^^^^^ File "/opt/odoo18/odoo/http.py", line 1943, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/http.py", line 2191, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/addons/base/models/ir_http.py", line 333, in _dispatch result = endpoint(**request.params) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/http.py", line 740, in route_wrapper result = endpoint(self, *args, **params_ok) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/addons/web/controllers/dataset.py", line 36, in call_kw return call_kw(request.env[model], method, args, kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/api.py", line 533, in call_kw result = getattr(recs, name)(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/oca/mis_builder/models/mis_report_instance.py", line 669, in copy return super().copy(default) ^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/models.py", line 5950, in copy vals_list = self.with_context(active_test=False).copy_data(default) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/odoo/models.py", line 5863, in copy_data lines = record[name].sorted(key='id').copy_data() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/odoo18/oca/mis_builder/models/mis_report_instance.py", line 464, in copy_data if self.source == SRC_CMPCOL: ^^^^^^^^^^^ File "/opt/odoo18/odoo/fields.py", line 1232, in get record.ensure_one() File "/opt/odoo18/odoo/models.py", line 6255, in ensure_one raise ValueError("Expected singleton: %s" % self) ValueError: Expected singleton: mis.report.instance.period(17, 18, 19)

The above server error caused the following client error: RPC_ERROR: Odoo Server Error RPC_ERROR at makeErrorFromResponse (http://127.0.0.1:8069/web/assets/1b537d2/web.assets_web.min.js:3148:163) at XMLHttpRequest. (http://127.0.0.1:8069/web/assets/1b537d2/web.assets_web.min.js:3153:13)

gjlong68 avatar Jun 03 '25 04:06 gjlong68

@gjlong68 can you open a separate issue with precisions on how to trigger the problem?

sbidoul avatar Jun 03 '25 13:06 sbidoul

See the attachment for details

郭Sir @.***

 

------------------ 原始邮件 ------------------ 发件人: "OCA/mis-builder" @.>; 发送时间: 2025年6月3日(星期二) 晚上11:39 @.>; @.@.>; 主题: Re: [OCA/mis-builder] Migration to version 18.0 (Issue #639)

Closed #639 as completed.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

gjlong68 avatar Jun 05 '25 07:06 gjlong68