mis-builder icon indicating copy to clipboard operation
mis-builder copied to clipboard
verified publisher icon OCA

[17.0][MIG] mis_builder

Open mpascuall opened this issue 1 year ago • 5 comments

Module migrated to version 17.0

cc https://github.com/APSL 154544

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review

mpascuall avatar Apr 30 '24 06:04 mpascuall

I'll have a look soon.

I've renamed the PR title :) Can you also reword the migration commit?

Also, can you rebase without 62359ca533ef4c00ed7352ad963c8963b6cab520? This was for python 3.9 support but Odoo 17 does not support it.

sbidoul avatar May 07 '24 16:05 sbidoul

/ocabot migration mis_builder

sbidoul avatar May 07 '24 16:05 sbidoul

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 07 '24 17:05 OCA-git-bot

Could you also cherry-pick https://github.com/OCA/mis-builder/pull/587 ?

sbidoul avatar May 10 '24 17:05 sbidoul

@manuelregidor @Tisho99 could u review please?

ValentinVinagre avatar May 14 '24 15:05 ValentinVinagre

Any update @sbidoul?

peluko00 avatar May 22 '24 08:05 peluko00

There are still a couple of things I'd like to check. I'll try to do later this week or early next week.

sbidoul avatar May 22 '24 10:05 sbidoul

Ah, another thing, the button box on the report instance form does not look right:

image

image

Probably something with the classes on the button box div.

sbidoul avatar May 24 '24 16:05 sbidoul

Ah, another thing, the button box on the report instance form does not look right:

image

image

Probably something with the classes on the button box div.

Fixed

mpascuall avatar May 27 '24 10:05 mpascuall

Any updates on this? @sbidoul

mpascuall avatar Jun 10 '24 08:06 mpascuall

@mpascuall To me the buttons are still misplaced. In v16 they are on the right. I have not had time to look for a correct solution for this. But the oe_right oe_button_box classes we use here don't seem to work correctly in v17. Also it seems weird to add a btn class on button tags, but again I've not looked closely yet.

sbidoul avatar Jun 10 '24 08:06 sbidoul

@mpascuall To me the buttons are still misplaced. In v16 they are on the right. I have not had time to look for a correct solution for this. But the oe_right oe_button_box classes we use here don't seem to work correctly in v17. Also it seems weird to add a btn class on button tags, but again I've not looked closely yet.

Fixed, could you check it again please?

mpascuall avatar Jun 12 '24 11:06 mpascuall

@sbidoul Can our team help you in anything with this module? I'm sure it's close to be merged 😉

HaraldPanten avatar Jun 20 '24 16:06 HaraldPanten

Yes, it's close. I'll review the latest changes after my holidays. Also check if it works in wizard mode.

sbidoul avatar Jun 20 '24 19:06 sbidoul

Yes, it's close. I'll review the latest changes after my holidays. Also check if it works in wizard mode.

Nice. Enjoy your holidays 👍

HaraldPanten avatar Jun 21 '24 07:06 HaraldPanten

/ocabot merge nobump

sbidoul avatar Jul 08 '24 12:07 sbidoul

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-607-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 08 '24 12:07 OCA-git-bot

Congratulations, your PR was merged at 244aded53a9079cc4c205ce5f83fd30b15c3b4db. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 08 '24 12:07 OCA-git-bot