margin-analysis icon indicating copy to clipboard operation
margin-analysis copied to clipboard

[IMP] sale_report_margin report field purchase_price

Open sistecem opened this issue 1 year ago • 6 comments

In the report it is more useful the total cost than the unit cost. It also gave wrong data when 2 lines of the same product where used

sistecem avatar Mar 19 '24 21:03 sistecem

Hi @sergio-teruel, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Mar 19 '24 21:03 OCA-git-bot

Sorry @sistecem The purchase_price field in Odoo core is by unit so to maintain data consistency it should be kept as a unit price.

Selección_2586

sergio-teruel avatar Mar 20 '24 09:03 sergio-teruel

Thanks @sergio-teruel , I agree with keeping the consistency , but i think it should be AVG instead of SUM

image image

sistecem avatar Mar 20 '24 12:03 sistecem

I also added the field purchase_price_total , as an option in the report , resultin in something like this image

sistecem avatar Mar 20 '24 13:03 sistecem

Sorry for the mess, I am still learning to contribute to the OCA I can make a new pull request if necessary Will do spanish translation if neccesary

sistecem avatar Mar 20 '24 13:03 sistecem

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 21 '24 12:07 github-actions[bot]