management-system icon indicating copy to clipboard operation
management-system copied to clipboard

[MIG][17.0] mgmtsystem_nonconformity

Open EdgarRetes opened this issue 1 year ago • 4 comments

EdgarRetes avatar Sep 24 '24 22:09 EdgarRetes

/ocabot migration mgmtsystem_nonconformity

max3903 avatar Sep 24 '24 23:09 max3903

Thanks for this migration. There are some warnings in the test log. Can you please attend to them?

bosd avatar Sep 25 '24 17:09 bosd

Can you merge migration commits into one please @EdgarRetes

peluko00 avatar Oct 01 '24 13:10 peluko00

Can you merge migration commits into one please @EdgarRetes

Done!

EdgarRetes avatar Oct 02 '24 16:10 EdgarRetes

Hi @EdgarRetes, I did a test on runboat and found some issues. In particular for me there are some errors in nonconformity view migration for example on the invisibility rule for Actions and Causes and Analysis, where attrs="{'invisible':[('state','in',['draft','cancel'])]}" is refactored as invisible="state not in 'draft' and state not in 'cancel'". I changed the code on the fly in runboat and it allows me to go further with state change (after filling the required fields). Please let me know if I'm wrong and if I can help in some way.

You are right, I had them wrong. Thanks for your comment! Let me know if you have some other erros

EdgarRetes avatar Oct 08 '24 19:10 EdgarRetes

You are right, I had them wrong. Thanks for your comment! Let me know if you have some other erros

I don't know if it's my problem, but I don't see the runboat link to test it. Maybe you need to push again to update the generation? Thanks

mymage avatar Oct 09 '24 06:10 mymage

You are right, I had them wrong. Thanks for your comment! Let me know if you have some other erros

I don't know if it's my problem, but I don't see the runboat link to test it. Maybe you need to push again to update the generation? Thanks

I just pushed it again

EdgarRetes avatar Oct 09 '24 16:10 EdgarRetes

/ocabot merge nobump

max3903 avatar Oct 10 '24 17:10 max3903

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-596-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 10 '24 17:10 OCA-git-bot

It looks like something changed on 17.0 in the meantime. Let me try again (no action is required from you). Prepared branch 17.0-ocabot-merge-pr-596-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 10 '24 17:10 OCA-git-bot

Congratulations, your PR was merged at 5ad92f061b9a92f110a5618ae3f92a6c58e58e47. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 10 '24 17:10 OCA-git-bot