l10n-netherlands icon indicating copy to clipboard operation
l10n-netherlands copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[13.0][MIG] l10n_nl_openkvk

Open astirpe opened this issue 4 years ago • 7 comments

Depends on:

  • [x] https://github.com/OCA/l10n-netherlands/pull/274
  • [x] https://github.com/OCA/l10n-netherlands/pull/275
  • [ ] https://github.com/OCA/l10n-netherlands/pull/276

astirpe avatar Sep 07 '20 10:09 astirpe

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 26 '21 12:09 github-actions[bot]

Can this one be reopened and merged?

bosd avatar Apr 15 '22 05:04 bosd

Can you rebase / force push?? To create a runboat.

Is onestein working on migrating this one to v14?

bosd avatar Apr 15 '22 06:04 bosd

Oops, forget my comment for now. I see that the dependency partner_coc still is not migrated to V13 and V14

bosd avatar Apr 15 '22 15:04 bosd

:pray: @astirpe Can you move forward with this one??

Once this is merged, want to move it forward to V14.

bosd avatar May 04 '22 08:05 bosd

@bosd I would like to do that but it's difficult for me to find enough time in this moment. This module depends on an old PR https://github.com/OCA/l10n-netherlands/pull/276 that was closed in the meantime and in any case it should be re-adapted with the new API changes: see https://github.com/OCA/l10n-netherlands/pull/345 Do you mind to take over this PR and the other one?

astirpe avatar May 04 '22 10:05 astirpe

Will see what I can do. ( Hope my coding skills are sufficient.) At first I had a little problem understanding the structure of the code. From an user perspective one would either use the "openkvk" api (for SME's) or official (paid) kvk api. It is undocumented, the openkvk provides an limited amount of free (as in free beer) lookups.

Having these 2 modules depend on each other from that point of view does not make sense. But for code re-usage maybe it is.

bosd avatar May 04 '22 11:05 bosd

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 11 '24 12:08 github-actions[bot]