interface-github icon indicating copy to clipboard operation
interface-github copied to clipboard

[15.0][IMP] github_connector_odoo: Remove uninstallable

Open hhgabelgaard opened this issue 1 year ago • 2 comments

The default for installable is True

hhgabelgaard avatar Nov 24 '24 08:11 hhgabelgaard

Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

And why removing the module instead of marking it uninstallable?

pedrobaeza avatar Nov 24 '24 11:11 pedrobaeza

@pedrobaeza There is no installable/uninstallable flag on odoo.module.version model afaik And current operation is to only add odoo.module.version records if the addon is installable. Like when the source is no longer present. But we could add an installable flag. Or add 'active' field?

Commit message updated

hhgabelgaard avatar Nov 24 '24 15:11 hhgabelgaard

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 08 '25 12:06 github-actions[bot]

/ocabot merge patch

pedrobaeza avatar Jun 08 '25 13:06 pedrobaeza

What a great day to merge this nice PR. Let's do it! Prepared branch 15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot avatar Jun 08 '25 13:06 OCA-git-bot

@pedrobaeza The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch:15.0 failed with output:

To https://github.com/OCA/interface-github
 ! [rejected]        15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch -> 15.0 (fetch first)
error: failed to push some refs to 'https://github.com/OCA/interface-github'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

OCA-git-bot avatar Jun 08 '25 13:06 OCA-git-bot

Congratulations, your PR was merged at f57a30cf96d88dcb21cfafca8c1ec8820471489e. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 08 '25 13:06 OCA-git-bot