interface-github icon indicating copy to clipboard operation
interface-github copied to clipboard

[ADD] github_connector_pull_request

Open SirAionTech opened this issue 2 years ago • 7 comments

SirAionTech avatar Sep 26 '23 14:09 SirAionTech

nice work ! code review. No test. I wonder if we should add a cron to synchronize PR regularly.

like in the core module : https://github.com/OCA/interface-github/blob/14.0/github_connector/data/ir_cron.xml

Thanks for your review! I was looking forward to your feedback specifically because you implemented the core modules. I added the CRON

SirAionTech avatar Sep 27 '23 07:09 SirAionTech

  • If we install github_connector, we expect to have the possibility to fetch also the PRs, not only the branches, and the code ? ...

Proposing to improve the existing module. What do you think ?

I see Pull Requests as a temporary object, I think most users should only be interested in the main branches. The ordinary user might then be not interested in the Pull Requests, so it should not install the additional module.

We implemented this module because we are also interested in what is the work in progress of some repositories.

did you thought to fetch also comments ?

No

SirAionTech avatar Sep 27 '23 14:09 SirAionTech

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 28 '24 12:01 github-actions[bot]

Any news on this one?

SirAionTech avatar Jan 29 '24 08:01 SirAionTech

I'm abstaining on this one!

legalsylvain avatar Jan 29 '24 08:01 legalsylvain

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 09 '24 12:06 github-actions[bot]

Rebased on 14.0.

SirAionTech avatar Jun 10 '24 07:06 SirAionTech