OCA
[16.0][MIG] mig hr_employee_id
- Updated the fields syntax in hr_employee_id/views/hr_employee_views.xml
- Updated the create method in models/hr_employee.py to not break batch mode create
- Add test : test_generate_identification_id_exception
To replace https://github.com/OCA/hr/pull/1340 wich seems stuck
The migration issue (#1141) has not been updated to reference the current pull request because a previous pull request (#1340) is not closed. Perhaps you should check that there is no duplicate work. CC @Chirag-OSI
@maisim you should do the migration commits as in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 and do the improvements separately. As for #1340 - I'll follow the @pedrobaeza's lead here
Hi @alexey-pelykh @pedrobaeza
I separated my changes into different commits. However, they are all necessary for 16.0 to be happy. So, in my opinion, they have their place in the migration PR. I hope it suits you like that.
There's no answer in the other PR, so let's use this one.
/ocabot migration hr_employee_id
:hand: @gurneyalex @nimarosa @Saran440 I see you have done a review for previous migrations of this module, could you take a look at it here? Thanks! :kissing:
/ocabot merge nobump
Functional test okay in runnoat. Code looks good too.
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-1373-by-nimarosa-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 2ebbe1a44c1e8d28f5256c785635d05d555c1355. Thanks a lot for contributing to OCA. ❤️