[17.0][FIX] hr_employee_second_lastname: removed useless mapped address_home_id

[DorianMAG]

Remove useless mapped. The source code has changed in OCB/OdooSA. The relational field no longer exists on the address in V17. https://github.com/OCA/OCB/blob/3afef8250c829406a8fd227a6bd9f71c4f80ff29/addons/hr/models/hr_employee.py#L49

[OCA-git-bot]

Hi @luisg123v, some modules you are maintaining are being modified, check this out!

[DorianMAG]

Regarding commit message:

* Title doesn't conform guidelines

* Missing commit description

Besides, regarding PR description:

* Not clear enough, why the OCB should affect? This should work with mnative Odoo

* Link is not a permalink

Hi @luisg123v Thank you for your review. The commit description is corrected. I updated my message regarding the OCB/OdooSA source code. Updating the link with a permalink.

Regards

[DorianMAG]

If the partner_firstname module is installed, this makes it impossible to install this module, because the address_home_id field no longer exists in v17, and it is replaced by a non-relational field which therefore no longer returns a recordset partner

[flotho]

Hi @luisg123v , any chance to have a new review here ?

[DorianMAG]

• Missing commit description.

  • Please rebase to see if CI is fixed.

Done regards

[dreispt]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1370-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

It looks like something changed on 17.0 in the meantime. Let me try again (no action is required from you). Prepared branch 17.0-ocabot-merge-pr-1370-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 6b57685fc0b04dcf7be1b29237ecf53a84c51d38. Thanks a lot for contributing to OCA. ❤️