hr icon indicating copy to clipboard operation
hr copied to clipboard

[14.0][FIX] hr_employee_birthay_mail: res_users configurable

Open JoanSForgeFlow opened this issue 2 years ago • 8 comments

This PR allows each user to grant permission for anniversary notifications from "My profile", otherwise only HR administrators can edit it.

The group "hr.group_hr_user" is also added. Without this group, the open attendances at that time fail and do not allow the attendance session to be closed.

@ForgeFlow

JoanSForgeFlow avatar Jul 10 '23 08:07 JoanSForgeFlow

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 15 '23 09:07 OCA-git-bot

/ocabot merge minor

dreispt avatar Nov 02 '23 20:11 dreispt

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot avatar Nov 02 '23 20:11 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Nov 02 '23 20:11 OCA-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 23 '24 12:06 github-actions[bot]

@dreispt Is it possible to reopoen and merge? I think it is a needed fix for the module.

Thank you

JoanSForgeFlow avatar Jul 30 '24 07:07 JoanSForgeFlow

Sure, can you rebase please?

dreispt avatar Jul 30 '24 10:07 dreispt

@dreispt Yes, of course. Done!

JoanSForgeFlow avatar Jul 30 '24 11:07 JoanSForgeFlow