[18.0][MIG] hr_expense_advance_clearing

[Saran440]

• change method action_sheet_move_create to action_sheet_move_post
• refactor return advance and add smart button on advance
• fixed case clearing exceed advance, can't register payment. reference https://github.com/odoo/odoo/blob/18.0/addons/account/models/account_move.py#L5095

[Saran440]

/ocabot migration hr_expense_advance_clearing

[hitrosol]

Hi @Saran440 I would like to perform a functional review on this, but the Runboat is not activated. Could you please activate it?

[Saran440]

@hitrosol I fixed it. please recheck again.

[gjlong68]

error

[Saran440]

@gjlong68 Can you add steps to reproduce, please? I tested and it not error.

My step is:

1. Create new account with Type Current Asset and Allow Reconcilation

2. Add new account to product advance

3. Create advance

4. Return Advance. it's fine. (not error)

[gjlong68]

account type is set error,change to Current Asset and Allow Reconcilation,is OK. 

郭Sir @.***

 

------------------ 原始邮件 ------------------ 发件人: "Saran @ @.>; 发送时间: 2025年4月16日(星期三) 下午4:21 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [OCA/hr-expense] [18.0][MIG] hr_expense_advance_clearing (PR #284)

@gjlong68 Can you add steps to reproduce, please? I tested and it not error.

My step is:

Create new account with Type Current Asset and Allow Reconcilation Selection_014.png (view on web)

Add new account to product advance Selection_015.png (view on web)

Create advance

Return Advance. it's fine. (not error) Selection_016.png (view on web)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***> Saran440 left a comment (OCA/hr-expense#284)

@gjlong68 Can you add steps to reproduce, please? I tested and it not error.

My step is:

Create new account with Type Current Asset and Allow Reconcilation Selection_014.png (view on web)

Add new account to product advance Selection_015.png (view on web)

Create advance

Return Advance. it's fine. (not error) Selection_016.png (view on web)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Saran440]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 18.0-ocabot-merge-pr-284-by-Saran440-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 55002a339f11247b1e08b9e59e18d2434e28785b. Thanks a lot for contributing to OCA. ❤️

[gjlong68]

expense-clearing.docx