helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard

[17.0][MIG] helpdesk_timesheet_time_type: Migration to 17.0

Open lbarry-apsl opened this issue 8 months ago • 3 comments

Module migrated to version 17.0

cc https://github.com/APSL 7983 @miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko @peluko00 please review

#523

lbarry-apsl avatar Apr 10 '25 10:04 lbarry-apsl

Hi @lbarry-apsl. This module depends on hr_timesheet_time_type which is not migrated to v17. Once a pr is created, you should follow this guideline: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

mpascuall avatar Apr 10 '25 10:04 mpascuall

Depends on:

  • [helpdesk_mgmt_timesheet] https://github.com/OCA/helpdesk/pull/695
  • [hr_timesheet_time_type] https://github.com/OCA/timesheet/pull/762

lbarry-apsl avatar Apr 10 '25 10:04 lbarry-apsl

Hi @lbarry-apsl. This module depends on hr_timesheet_time_type which is not migrated to v17. Once a pr is created, you should follow this guideline: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Done! Thanks!

lbarry-apsl avatar Apr 10 '25 14:04 lbarry-apsl

/ocabot merge nobump

lbarry-apsl avatar Apr 14 '25 05:04 lbarry-apsl

Sorry @lbarry-apsl you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

OCA-git-bot avatar Apr 14 '25 05:04 OCA-git-bot

@pedrobaeza , can this be merged?

lbarry-apsl avatar Apr 14 '25 05:04 lbarry-apsl

/ocabot migration helpdesk_timesheet_time_type /ocabot merge nobump

pedrobaeza avatar Apr 14 '25 06:04 pedrobaeza

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Apr 14 '25 06:04 OCA-git-bot

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 14 '25 06:04 OCA-git-bot

Remove the temporary reference.

pedrobaeza avatar Apr 14 '25 06:04 pedrobaeza

/ocabot merge nobump

pedrobaeza avatar Apr 14 '25 07:04 pedrobaeza

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Apr 14 '25 07:04 OCA-git-bot

Congratulations, your PR was merged at e05eb55ac2f9463a774298c68f97d0fa0a3d19e2. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Apr 14 '25 07:04 OCA-git-bot