helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard
verified publisher icon OCA

[16.0][IMP]helpdesk_mgmt: simplify email templates

Open PicchiSeba opened this issue 1 year ago • 4 comments

Forward-ports https://github.com/OCA/helpdesk/pull/467 which itself partially forward-ported 98e5ef7f4a2e074283da3674654f662a28f02eed and dfbc3698e76b3a1330f339ca78b49557b78c05ed from 12.0 to 14.0

PicchiSeba avatar Oct 21 '24 11:10 PicchiSeba

I just rebased because of a conflict arising from the merge of #643

PicchiSeba avatar Nov 25 '24 08:11 PicchiSeba

I removed the unrelated commit, the new email template (will do another PR for that) and the stage_id forced assignment in the controller. I also converted the email templates to the 16.0 format.

Do you see any other critical issue?

PicchiSeba avatar Nov 26 '24 09:11 PicchiSeba

I see 3 different purposes to this PR

  • Refactoring email templates (LGTM on that front)
  • Improving how access to tickets is handled for portal users (LGTM on that front too, and it's closely related)
  • Hardcoding sending an email on ticket creation no matter what (I have some question, and perhaps this could be split in a different PR?)

aleuffre avatar Nov 26 '24 10:11 aleuffre

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Apr 06 '25 12:04 github-actions[bot]