helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard

[16.0][ADD]helpdesk_mgmt_timesheet_time_type: Use time type in ticket timesheet

Open flotho opened this issue 1 year ago • 13 comments

supersedes https://github.com/OCA/helpdesk/pull/517

flotho avatar Jul 01 '24 19:07 flotho

Please clean the branch of merge commits + check the CI.

pedrobaeza avatar Jul 01 '24 19:07 pedrobaeza

Hi @pedrobaeza a great thanks for your support and fast review. We should be better now, Let me know

flotho avatar Jul 01 '24 20:07 flotho

hi @OCA/helpdesk-maintainers ready for review here

flotho avatar Jul 05 '24 11:07 flotho

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 06 '24 20:07 OCA-git-bot

any chance to be merged ?

flotho avatar Aug 28 '24 20:08 flotho

Hi @OCA/helpdesk-maintainers , any chance to be merged ?

flotho avatar Sep 10 '24 14:09 flotho

Hi @OCA/helpdesk-maintainers, any chance to be merged ?

flotho avatar Jan 11 '25 22:01 flotho

ping @pedrobaeza , sorry for buzzing you, what is the process to be merged once all the tags are valid ?

flotho avatar Jan 14 '25 08:01 flotho

A PSC should review it and merge it.

pedrobaeza avatar Jan 14 '25 08:01 pedrobaeza

A PSC should review it and merge it.

Thnaks @pedrobaeza , are we talking about members here https://github.com/orgs/OCA/teams/helpdesk-maintainers ? Or those one https://odoo-community.org/psc-teams/helpdesk-164 ?

What is the proper process to ping a PSC without direct buzzing like I'm doing now with you ? (one more time, sorry for this but I still discovering tips to follow properly the process)

flotho avatar Jan 14 '25 10:01 flotho

Ping the team

pedrobaeza avatar Jan 14 '25 10:01 pedrobaeza

Anyway, you shouldn't expect reactivity. Perhaps you can review other PRs and ask in exchange that they review yours.

pedrobaeza avatar Jan 14 '25 10:01 pedrobaeza

Thanks @pedrobaeza I hope that I'm not suspected of expecting reactivity as you can see on the timeline ;-) : image

I'm just asking the proper process as I see many PR with both label available and not only mines. Having all the tags on the PR and letting the PR not merged could be hard for people who are contributing. Once I will better understand the process I'would love to help to merge more PR.

And of course I will review more !

flotho avatar Jan 14 '25 11:01 flotho

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 18 '25 12:05 github-actions[bot]