helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard

[14.0] [FIX] helpdesk_mgmt_fieldservice: improve _compute_all_closed method

Open renda-dev opened this issue 1 year ago • 4 comments

proposing again https://github.com/OCA/helpdesk/pull/454

(changes made to helpdesk_mgmt_fieldservice/static/description/index.html are from pre-commit)

@OCA/helpdesk-maintainers


Checking a boolean field is more reliable than checking arbitrary names that can be changed by the user

renda-dev avatar Jun 17 '24 11:06 renda-dev

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Feb 16 '25 12:02 github-actions[bot]

@renda-dev please rebase.

marcelsavegnago avatar Feb 21 '25 12:02 marcelsavegnago

@renda-dev please rebase.

Done 👍🏼

renda-dev avatar Feb 21 '25 12:02 renda-dev

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 21 '25 12:02 OCA-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 29 '25 12:06 github-actions[bot]

@pedrobaeza @DarioLodeiros Sorry to bother you both — do you have any suggestions regarding the versioning? It's currently defined as a patch, but I'm not sure if that's appropriate.

marcelsavegnago avatar Jun 30 '25 13:06 marcelsavegnago

/ocabot merge patch

pedrobaeza avatar Jun 30 '25 13:06 pedrobaeza

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-592-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot avatar Jun 30 '25 13:06 OCA-git-bot

Congratulations, your PR was merged at 8bbab3a9868717192338821932c14c5cdfdd5eea. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 30 '25 13:06 OCA-git-bot