helpdesk
helpdesk copied to clipboard
[14.0] [FIX] helpdesk_mgmt_fieldservice: improve _compute_all_closed method
proposing again https://github.com/OCA/helpdesk/pull/454
(changes made to helpdesk_mgmt_fieldservice/static/description/index.html are from pre-commit)
@OCA/helpdesk-maintainers
Checking a boolean field is more reliable than checking arbitrary names that can be changed by the user
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
@renda-dev please rebase.
@renda-dev please rebase.
Done 👍🏼
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
@pedrobaeza @DarioLodeiros Sorry to bother you both — do you have any suggestions regarding the versioning? It's currently defined as a patch, but I'm not sure if that's appropriate.
/ocabot merge patch
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-592-by-pedrobaeza-bump-patch, awaiting test results.
Congratulations, your PR was merged at 8bbab3a9868717192338821932c14c5cdfdd5eea. Thanks a lot for contributing to OCA. ❤️