helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard

[16.0][IMP]helpdesk_mgmt: interface improvements

Open flotho opened this issue 1 year ago • 17 comments

Depends on :

  • [x] https://github.com/OCA/helpdesk/pull/585
  • [X] https://github.com/OCA/helpdesk/pull/583

Backend Improvements :

  • [x] Add kanban state in multiple views
  • [x] Reset kanban state when changing the stage
  • [x] Refactor the form view to be closer to task's one
  • [x] New ticket view with searchpanel and default filter

Portal improvements :

  • [x] Change submission button size in the home of the portal user
  • [x] Refactor the list view :
  • Default group by stage when reaching the list view
  • Change columns to be more consistent with tasks
  • Change the css on groups and lines to be more concise

flotho avatar May 31 '24 17:05 flotho

Purpose is to boost the user experience backend : image

image

some improvements inspired from https://github.com/OCA/helpdesk/pull/556 . @eLBati how do you want me to mention it ?

flotho avatar May 31 '24 19:05 flotho

Regarding the portal, multiple things could be imporved as proposed there : https://github.com/OCA/helpdesk/pull/577 It looks difficut to proper alter/inherit portal_docs_entry to add the button as proposed by @pedrobaeza So my proposal is to use css to grow on all the line : image

flotho avatar May 31 '24 20:05 flotho

Ive also changed the view list : image

flotho avatar May 31 '24 22:05 flotho

how do you want me to mention it ?

Hi @flotho you could cherry-pick the commit, if applicable

eLBati avatar Jun 05 '24 07:06 eLBati

Hi @eLBati , thanks, I'll do another try since dependencies have nbeen merged

flotho avatar Jun 05 '24 07:06 flotho

how do you want me to mention it ?

Hi @flotho you could cherry-pick the commit, if applicable

cherry pick done

flotho avatar Jun 07 '24 20:06 flotho

Hi @eLBati ,

Your review will be appreciated

Regards

flotho avatar Jun 07 '24 22:06 flotho

Hi @eLBati @DorianMAG @gaelTorrecillas , @JulienMartinez , any review here would be appreciated

flotho avatar Jun 11 '24 11:06 flotho

Hi @marcelsavegnago , your review would be appreciated here as it impacts the portal

flotho avatar Jun 11 '24 17:06 flotho

pop @JulienMartinez , your review is expected here

flotho avatar Jun 12 '24 18:06 flotho

hum.... @pedrobaeza ould you help me regarding the codecov? Looks like only readme is concerned. Do I have to reset the readme file ?

Regards

flotho avatar Jul 01 '24 20:07 flotho

hum, the codecov failed on a the commit https://github.com/OCA/helpdesk/commit/bc8e7407a66c01b0adf4cd4ef5e869534dc092cd that is part of a post merge commit

flotho avatar Jul 01 '24 20:07 flotho

hum, the codecov failed on a the commit bc8e740 that is part of a post merge commit

sorry to buzz @pedrobaeza , how can I get out from this situation, the codecov regression has been generated by a robot commit. In this case, what is the procedure ? Regards

flotho avatar Jul 02 '24 21:07 flotho

Don't get mad with that, as:

  1. Codecov check is not mandatory. It's just a metric, but it doesn't block the merge.
  2. In my experience, it's not working well, giving false reds.

pedrobaeza avatar Jul 03 '24 06:07 pedrobaeza

Please squash 1st, 2nd and 4th commit together, as they are not adding value as separated.

pedrobaeza avatar Jul 08 '24 18:07 pedrobaeza

Please squash 1st, 2nd and 4th commit together, as they are not adding value as separated.

done! thanks @pedrobaeza

flotho avatar Jul 09 '24 13:07 flotho

no more conflicts !

flotho avatar Jul 11 '24 20:07 flotho

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Feb 02 '25 12:02 github-actions[bot]