helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard

[15.0] [FIX] helpdesk_mgmt: company_id should come from team

Open eLBati opened this issue 1 year ago • 2 comments

Otherwise, creating tickets from fetchmail would always set odoobot's company in new tickets, potentially in contrast to team's company

eLBati avatar Mar 25 '24 13:03 eLBati

@eLBati , the company would be undefined in case it is created manually without adding any team

ByteMeAsap avatar Apr 03 '24 07:04 ByteMeAsap

@ByteMeAsap why do you think this would be a problem? Record rule helpdesk_ticket_comp_rule expects tickets without company.

Anyway, I also added _default_team_id , please review

Thanks

eLBati avatar Apr 12 '24 10:04 eLBati

/ocabot merge patch

rvalyi avatar Sep 04 '24 23:09 rvalyi

On my way to merge this fine PR! Prepared branch 15.0-ocabot-merge-pr-553-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot avatar Sep 04 '24 23:09 OCA-git-bot

Congratulations, your PR was merged at 1bff1120899d78fe93725243030b1785f9e1f3d1. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 04 '24 23:09 OCA-git-bot

Reverted in #619

See https://github.com/OCA/helpdesk/pull/618#pullrequestreview-2281927887

@rvalyi you merged just after I request the review of my colleague, which has been working on this question a lot. It's true that the PR has been here a lot of time, but we didn't see it, sorry. But this is breaking some flows that were designed to work that way. @victoralmau maybe you can add some tests for that flows.

pedrobaeza avatar Sep 05 '24 06:09 pedrobaeza

Replacing with https://github.com/OCA/helpdesk/pull/622

eLBati avatar Sep 05 '24 15:09 eLBati