helpdesk icon indicating copy to clipboard operation
helpdesk copied to clipboard

[FIX[[16] helpdesk_mgmt_project: Fix id instead of active_id used in smartbuttons

Open alessandro-fiorino opened this issue 1 year ago • 7 comments

Using active_id in the context is wrong because if landing in the project starting from another model, the active_id is the one of the previous model in the breadcrumb. ID should be used instead of active_id

alessandro-fiorino avatar Mar 08 '24 00:03 alessandro-fiorino

Please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

pedrobaeza avatar Mar 08 '24 01:03 pedrobaeza

Something else missing before approving this merge ?

alessandro-fiorino avatar Mar 23 '24 01:03 alessandro-fiorino

Something else missing before approving this merge ?

I believe Pedro meant you should amend (git commit --amend) your commit to change the message to something like:

"[FIX] helpdesk_mgmt_project: use id instead of active_id"

as per OCA guidelines here https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message Thank you for helping.

rvalyi avatar Mar 23 '24 02:03 rvalyi

Hi @alessandro-fiorino , any chance to rebase ?

flotho avatar Jul 01 '24 18:07 flotho

perfect, everything is green now. thanks, just have to wait ready to merge tag

flotho avatar Jul 01 '24 19:07 flotho

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 01 '24 19:07 OCA-git-bot

Is it ok now ?

alessandro-fiorino avatar Jul 01 '24 20:07 alessandro-fiorino