helpdesk
helpdesk copied to clipboard
[FIX[[16] helpdesk_mgmt_project: Fix id instead of active_id used in smartbuttons
Using active_id in the context is wrong because if landing in the project starting from another model, the active_id is the one of the previous model in the breadcrumb. ID should be used instead of active_id
Please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message
Something else missing before approving this merge ?
Something else missing before approving this merge ?
I believe Pedro meant you should amend (git commit --amend) your commit to change the message to something like:
"[FIX] helpdesk_mgmt_project: use id instead of active_id"
as per OCA guidelines here https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message Thank you for helping.
Hi @alessandro-fiorino , any chance to rebase ?
perfect, everything is green now. thanks, just have to wait ready to merge tag
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Is it ok now ?