helpdesk
helpdesk copied to clipboard
OCA
Make channel name translatable
[IMP] helpdesk_mgmt: Make channel name translatable
The channel name in multilanguage environments should be translatable to the system's active language. In case the channel name is not translatable, when the user is configuring the helpdesk for a multilanguage audience he is forced to choose one language only and that may become non understandable for all other languages.
Please follow the proper commit message (you did it in the comment putting [IMP] helpdesk_mgmt: Make channel name translatable, why not in the commit?)
Please follow the proper commit message (you did it in the comment putting
[IMP] helpdesk_mgmt: Make channel name translatable, why not in the commit?)
Sorry about that. I have very little experience with github. I guess I need to readup on the guidelines with a bit more of attention to detail. I genuinely thought I was doing it the right way.
For fixing it you have to checkout your branch, do git commit --all --amend, change the commit message and save the message editor, and then git push -f.
Please follow the proper commit message (you did it in the comment putting
[IMP] helpdesk_mgmt: Make channel name translatable, why not in the commit?)Sorry about that. I have very little experience with github. I guess I need to readup on the guidelines with a bit more of attention to detail. I genuinely thought I was doing it the right way.
nothing to worry about @peterromao , I personnaly receive @pedrobaeza comment on my own commit message and it's fairly normal. You'll see, he could be scary ;-) but when "OCA god" give you an advice it's for the good of the community. And BTW, it's because of those strict rules that you could make your business rely on this strong community. Alone you go fast, with @pedrobaeza and @OCA you go further !
Hi @peterromao , you're almost done on this PR, any chance to rebase to get the latest workflow setup?
Regards