geospatial icon indicating copy to clipboard operation
geospatial copied to clipboard

[17.0] [FIX] base_geoengine: ensure map view height is 100% of available area

Open sersanchus opened this issue 1 year ago • 3 comments

This fix ensures that the map view height correctly occupies 100% of the available area. The previous max-height: 90% workaround is no longer necessary, as the map view now uses a wrapper div with the CSS class o_action for the controller.

sersanchus avatar Nov 11 '24 18:11 sersanchus

Hello @peluko00, can you review this fix please?

sersanchus avatar Nov 11 '24 18:11 sersanchus

Hello @peluko00, can you review this fix please?

It's seems all good but the test are failing. Can you fix it? Thanks!

peluko00 avatar Nov 12 '24 07:11 peluko00

Hello @peluko00, can you review this fix please?

It's seems all good but the test are failing. Can you fix it? Thanks!

The failing test doesn't seem related to the commit. I guess that something in geoengine_base_geolocalize unit test data is wrong.

sersanchus avatar Nov 12 '24 09:11 sersanchus

It's ready for merge @max3903 ?

peluko00 avatar May 22 '25 07:05 peluko00

Ping @OCA/geospatial-maintainers

max3903 avatar May 22 '25 13:05 max3903

@yvaucher Can this fix be merged?

ping @OCA/geospatial-maintainers @pedrobaeza @lmignon

zamberjo avatar Aug 22 '25 06:08 zamberjo

/ocabot merge patch

lmignon avatar Aug 27 '25 06:08 lmignon

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-387-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot avatar Aug 27 '25 06:08 OCA-git-bot

Congratulations, your PR was merged at 1f65ac32c0c94444a9f8a7bc0aa2074542a5fd28. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Aug 27 '25 06:08 OCA-git-bot