field-service icon indicating copy to clipboard operation
field-service copied to clipboard

[12.0][FIX] Improved code of stage create method.

Open rutul-serpentcs opened this issue 5 years ago • 4 comments

When I create stage from Field Service >> Dashboard >> Team >> Orders kanban view I got an error.

Teams-Odoo

rutul-serpentcs avatar Sep 25 '20 10:09 rutul-serpentcs

Hi @max3903, @wolfhall, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Sep 25 '20 10:09 OCA-git-bot

@rutul-serpentcs This fixes the original error you presented. However there is still an issue creating the stage from Kanban view

The operation cannot be completed:
- Create/update: a mandatory field is not set.
- Delete: another model requires the record being deleted. If possible, archive it instead.

Model: Field Service Stage (fsm.stage), Field: Type (stage_type) 

stage_type field needs to be set

@brian10048 Done, Can you please review it again?

rutul-serpentcs avatar Sep 28 '20 07:09 rutul-serpentcs

@rutul-serpentcs - It allows to create the stage, but a new bug is introduced when we create a stage that has an undefined stage type. When you go back to the orders kanban view, the stage recently created will not be displayed.

Can you revert the recent change and keep the stage_type required in python? Then, instead can you use the context to set the correct stage_type based on the view

brian10048 avatar Sep 28 '20 16:09 brian10048

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 15 '22 12:05 github-actions[bot]