[18.0][MIG] fieldservice_stage_validation: Migration to 18.0
Migration of fieldservice_stage_validation module to Odoo 18.0.
Summary
- ✅ Proper migration using git format-patch method - preserves complete git history from 17.0 branch
- ✅ Updated module version to 18.0.1.0.0
- ✅ Fixed translation issue - use rec.env._ for proper translation context
- ✅ Applied all pre-commit fixes and formatting
- ✅ Follows OCA migration guidelines exactly
Module Description
This module adds field validation to FSM stages, allowing administrators to configure required fields that must be set before moving to specific stages in the field service workflow.
Migration Details
- Method: Used git format-patch to preserve complete git history (not manual copy)
- Code Changes: Updated translation calls to use proper rec.env._ context
- Quality: All pre-commit linting and formatting applied
- Testing: Ready for Runboat CI testing environment
Technical Changes
- Fixed: "no translation language detected" warning in validate_utils.py
- Updated: Manifest version format to 18.0.1.0.0
- Preserved: Full commit history from 17.0 branch
Closes part of migration checklist in OCA/field-service#1220
Hello!
Thanks for the contribution.
It seems, though, the module commit history is not preserved. Did you follow the steps mentioned here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch ?
Alternatively, there are these two libraries that make the process a bit smoother:
- https://github.com/oca/odoo-module-migrator
- https://github.com/oca/oca-port
Hello!
Thanks for the contribution.
It seems, though, the module commit history is not preserved. Did you follow the steps mentioned here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch ?
Alternatively, there are these two libraries that make the process a bit smoother:
* https://github.com/oca/odoo-module-migrator * https://github.com/oca/oca-port
I added previous history, since is my fist contribution am still learning the process.
There are some files added in one of your commits, and then removed in a following one:
Please clean that up. Also, maybe squash your commits into a single "Migration to 18.0" one, or at least keep only one for "pre-commit autofixes"