OCA
[16.0][FIX] fieldservice_geoengine: Restore geoengine views
Using templates for restoring geoengine views of "fsm.location" and "fsm.order" models.
Porting of PR #1325
Hi @max3903, @wolfhall, some modules you are maintaining are being modified, check this out!
Errors seen:
While clicking on orders and location names displayed to the right of geoengine map view, below error is seen:
Errors seen:
While clicking on orders and location names displayed to the right of geoengine map view, below error is seen:
This error is seen only when Latitude and Longitude information does not exist when user tries to change the "location information" such as city, state, country. Once latitude and longitude values are used to calculate shape value for geoengine, this error is not seen.
Adding constraint check based on "fsm.location" geoengine view for fields such as state_id, country_id to indicate UserError have impact on other modules which inherit "fsm.location". So, user has to make sure to update latitude and longitude details while updating address of "Location"
Errors seen: While clicking on orders and location names displayed to the right of geoengine map view, below error is seen:
This error is seen only when Latitude and Longitude information does not exist when user tries to change the "location information" such as city, state, country. Once latitude and longitude values are used to calculate shape value for geoengine, this error is not seen.
Adding constraint check based on "fsm.location" geoengine view for fields such as state_id, country_id to indicate UserError have impact on other modules which inherit "fsm.location". So, user has to make sure to update latitude and longitude details while updating address of "Location"
Obviously it shouldn't error out if the fields are not present, so I think a fix is warranted, but it's outside the scope of this PR.
Errors seen: While clicking on orders and location names displayed to the right of geoengine map view, below error is seen:
This error is seen only when Latitude and Longitude information does not exist when user tries to change the "location information" such as city, state, country. Once latitude and longitude values are used to calculate shape value for geoengine, this error is not seen. Adding constraint check based on "fsm.location" geoengine view for fields such as state_id, country_id to indicate UserError have impact on other modules which inherit "fsm.location". So, user has to make sure to update latitude and longitude details while updating address of "Location"
Obviously it shouldn't error out if the fields are not present, so I think a fix is warranted, but it's outside the scope of this PR.
Yes, a warning can be shown to user when location related information changed. Will make it as part of seperate PR
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@OCA/field-service-maintainers We've been using this fix in production for months now. Will FW once merged. Thanks!
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1342-by-brian10048-bump-minor, awaiting test results.
It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1342-by-brian10048-bump-minor, awaiting test results.
Congratulations, your PR was merged at 0823dbd13f05fd41b3ce32d44139646f97db6dbf. Thanks a lot for contributing to OCA. ❤️