field-service icon indicating copy to clipboard operation
field-service copied to clipboard

[18.0][MIG] fieldservice_account_analytic

Open EdgarRetes opened this issue 1 year ago • 13 comments

@max3903

EdgarRetes avatar Oct 15 '24 21:10 EdgarRetes

/ocabot migration fieldservice_account_analytic

max3903 avatar Oct 16 '24 05:10 max3903

/ocabot migration fieldservice_account_analytic

max3903 avatar Nov 15 '24 21:11 max3903

@brian10048 @max3903

EdgarRetes avatar Nov 22 '24 22:11 EdgarRetes

@EdgarRetes We need to create 3 analytic plans:

  • FSM Orders
  • FSM Locations
  • FSM Routes

and:

  • Create a new account in the FSM Orders plan for each order
  • Create a new account in the FSM Locations plan for each location
  • CReate a new account in the FSM Routes plan for each route

When creating the customer invoice, vendor bill line or timesheet entry, we need to set the corresponding analytic account in each plan.

We also need to activate the following settings/groups:

  • Technical/Analytic Accounting
  • Technical/Show Full Accounting Features --> Add a dependency on account_usability

max3903 avatar Nov 23 '24 20:11 max3903

@EdgarRetes We need to create 3 analytic plans:

* FSM Orders

* FSM Locations

* FSM Routes

and:

* Create a new account in the FSM Orders plan for each order

* Create a new account in the FSM Locations plan for each location

* CReate a new account in the FSM Routes plan for each route

When creating the customer invoice, vendor bill line or timesheet entry, we need to set the corresponding analytic account in each plan.

We also need to activate the following settings/groups:

* Technical/Analytic Accounting

* Technical/Show Full Accounting Features --> Add a dependency on account_usability

Account usability hasn't been merged yet. Once it is done you can test it

https://github.com/OCA/account-financial-tools/pull/1981

EdgarRetes avatar Nov 29 '24 22:11 EdgarRetes

@EdgarRetes

I think all the features around route can be moved to fieldservice and hidden with a group (activated in the settings).

All the analytic features can be moved to fieldservice_account and hidden with the existing group/setting.

max3903 avatar Dec 06 '24 13:12 max3903

@EdgarRetes

I think all the features around route can be moved to fieldservice and hidden with a group (activated in the settings).

All the analytic features can be moved to fieldservice_account and hidden with the existing group/setting.

Do you have any example of a repository that does this?

EdgarRetes avatar Dec 06 '24 18:12 EdgarRetes

@max3903 since the changes you're proposing are, if I'm not mistaken, refactoring of the actual logic and this PR is stale for a long time, don't you think we can postpone the refactoring to a later PR and prioritize the pure migration of the logic as-is? Also, this module not migrated 'blocks' the migration of fieldservice_isp_account.

Do you think this could be feasible? Thanks

are-agilebg avatar Mar 10 '25 16:03 are-agilebg

Let me discuss it with @santiagordz and give it higher priority.

max3903 avatar Mar 10 '25 19:03 max3903

Let me discuss it with @santiagordz and give it higher priority.

Sorry if I bother you: have you had a chance to discuss it?

are-agilebg avatar Apr 28 '25 09:04 are-agilebg

Sorry if I bother you: have you had a chance to discuss it?

Nope. @SMaciasOSI Can you get this in the todo list of @dcamacho20?

max3903 avatar Apr 28 '25 17:04 max3903

Sorry if I bother you: have you had a chance to discuss it?

Nope. @SMaciasOSI Can you get this in the todo list of @dcamacho20?

Thanks for looking into it! We'll probably start anyway to migrate fieldservice_isp_account internally to 18.0 using this open PR as a dependency.

are-agilebg avatar May 22 '25 11:05 are-agilebg

Hello :wave: I'm migrating fieldservice_isp_account (https://github.com/OCA/field-service/pull/1442) but several unit tests are failing because of required fields introduced in fieldservice_account_analytic. Example: fieldservice_crm (which doesn't depend on fieldservice_account_analytic) fails to create a fsm.location because the required field customer_id is not present.

@EdgarRetes would you mind rebasing this PR? I suspect the CI will fail too: some modules have been merged meanwhile.

vvrossem avatar Aug 19 '25 11:08 vvrossem