field-service icon indicating copy to clipboard operation
field-service copied to clipboard

[14.0][FIX] fieldservice_account_analytic: Write correct value for customer_id

Open michelerusti opened this issue 2 years ago • 4 comments

The value for customer_id was written with the wrong value as the order.location_id.customer_id points to a different value than the sale order that generates the fsm_order

Also, it was not written at creation

michelerusti avatar May 10 '23 15:05 michelerusti

Hi @brian10048, @bodedra, @osimallen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar May 10 '23 15:05 OCA-git-bot

@michelerusti If you could set those fields in vals before calling super(), they would be set as part of the same transactions.

max3903 avatar May 11 '23 16:05 max3903

@michelerusti If you could set those fields in vals before calling super(), they would be set as part of the same transactions.

Yes, thanks for the advise I've also removed the error assertion in test_fsm_stock_account.py because with this fix the user is set correctly

Let me know if there's anything else needed to do!

michelerusti avatar May 16 '23 10:05 michelerusti

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Apr 14 '24 14:04 github-actions[bot]